ansible: 2.19.4 -> 2.20.0

[robsliwi]

Changelog: https://github.com/ansible/ansible/blob/v2.20.0/changelogs/CHANGELOG-v2.20.rst

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[dotlambda]

I thought we're trying to avoid these now: #421201

[robsliwi]

Thanks for letting me know, haven't stumbled across this PR and the involved discussions yet. What would your proposal be? Removal of all Ansible versions that are using the overrides?

[dotlambda]

I would add a package ansible_2_19 under pkgs/by-name that copies the expression for ansible-core instead of using overridePythonAttrs.
And yeah, consider removing old versions that we don't need anymore. Why do we keep them around rather than having downstream users do the overriding themselves if they absolutely have to?

[HarisDotParis]

Ansible and ansible-core are currently part of pkgs/development/python-modules, also I myself am not sure how to do this as I want to reuse code but create a new package, right? Do you know of some good blueprint for the changes necessary?

[robsliwi]

Just thought about a bit and grepped at least through nixpkgs for the usage of the "older" versions and there was none.
We had reports about a build failure of ansible_2_17 in September but we can easily teach how to use "an older version" with overrides, an older commit of nixpkgs, etc.

Let's remove them and see what breaks and if somebody complains. Tried to achieve it with 89837eb but I'm not sure if the commit message fits the scheme. Otherwise I can remove them one by one to increase my commit count 📈 🤡

[dotlambda]

I would do one commit per package that you remove. Also make sure to add an entry to pkgs/top-level/aliases.nix.

[mkg20001]

I would like to vouch for keeping older versions, at least some

Upgrading ansible is sometimes associated with breakage and keeping one or two relativly new versions should be ok

[dotlambda]

I would like to vouch for keeping older versions, at least some

Upgrading ansible is sometimes associated with breakage and keeping one or two relativly new versions should be ok

Then we should have a policy around which (or how many) versions to keep and we should move them to separate expressions.

[robsliwi]

Upgrading ansible is sometimes associated with breakage and keeping one or two relativly new versions should be ok

I know this pain. But actually with Nix there is no problem with running ansible from an older nixpkgs commit.
And if it's really really needed for whatever specific reason there are the overrides that allow you to achieve whatever version you want, even one that is not in nixpkgs, not cached, or whatever.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6135

[dotlambda]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 458928
Commit: 47b2c8d0affdd4bdef0a12387c6967b0a9acc849

---

x86_64-linux

✅ 43 packages built:

• ansible (python313Packages.ansible-core)
• ansible-doctor
• ansible-doctor.dist
• ansible-lint
• ansible-lint.dist
• ansible-navigator
• ansible-navigator.dist
• ansible.dist (python313Packages.ansible-core.dist)
• molecule (python313Packages.molecule)
• molecule.dist (python313Packages.molecule.dist)
• python312Packages.ansible-compat
• python312Packages.ansible-compat.dist
• python312Packages.ansible-core
• python312Packages.ansible-core.dist
• python312Packages.ansible-kernel
• python312Packages.ansible-kernel.dist
• python312Packages.ansible-runner
• python312Packages.ansible-runner.dist
• python312Packages.ansible-vault-rw
• python312Packages.ansible-vault-rw.dist
• python312Packages.dynaconf
• python312Packages.dynaconf.dist
• python312Packages.molecule
• python312Packages.molecule.dist
• python312Packages.pytest-ansible
• python312Packages.pytest-ansible.dist
• python312Packages.pytest-testinfra
• python312Packages.pytest-testinfra.dist
• python313Packages.ansible-compat
• python313Packages.ansible-compat.dist
• python313Packages.ansible-kernel
• python313Packages.ansible-kernel.dist
• python313Packages.ansible-runner
• python313Packages.ansible-runner.dist
• python313Packages.ansible-vault-rw
• python313Packages.ansible-vault-rw.dist
• python313Packages.dynaconf
• python313Packages.dynaconf.dist
• python313Packages.pytest-ansible
• python313Packages.pytest-ansible.dist
• python313Packages.pytest-testinfra
• python313Packages.pytest-testinfra.dist
• scap-security-guide