Skip to content

onnxruntime: only add cuda_nvcc to disallowedRequisites when cudaSupport is enabled#458835

Merged
ConnorBaker merged 1 commit intoNixOS:masterfrom
GaetanLepage:disallowed-requisites
Nov 5, 2025
Merged

onnxruntime: only add cuda_nvcc to disallowedRequisites when cudaSupport is enabled#458835
ConnorBaker merged 1 commit intoNixOS:masterfrom
GaetanLepage:disallowed-requisites

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 5, 2025

Things done

Addresses #457803 (comment).

cc @SomeoneSerge

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage mentioned this pull request Nov 5, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 5, 2025
@nix-owners nix-owners bot requested review from ck3d and puffnfresh November 5, 2025 14:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Nov 5, 2025
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Nov 5, 2025
vcunat
vcunat approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 5, 2025
@ConnorBaker ConnorBaker added this pull request to the merge queue Nov 5, 2025
Merged via the queue into NixOS:master with commit a71dd19 Nov 5, 2025
33 of 37 checks passed
@GaetanLepage GaetanLepage deleted the disallowed-requisites branch November 5, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcunat vcunat vcunat approved these changes

@ConnorBaker ConnorBaker ConnorBaker approved these changes

@SomeoneSerge SomeoneSerge Awaiting requested review from SomeoneSerge

@ck3d ck3d Awaiting requested review from ck3d

@puffnfresh puffnfresh Awaiting requested review from puffnfresh

Assignees

No one assigned

Labels

1.severity: channel blocker Blocks a channel 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @vcunat @ConnorBaker