Skip to content

haskellPackages.nix-paths: fix after upload of nix hackage package#457300

Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:nix-paths-no-build-tools
Oct 31, 2025
Merged

haskellPackages.nix-paths: fix after upload of nix hackage package#457300
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:nix-paths-no-build-tools

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Oct 31, 2025 •
edited
Loading

Things done

Compare NixOS/cabal2nix#683, b69a739

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@sternenseemann
haskellPackages.nix-paths: provide pkgs.nix for libraryToolDepends
2d2cef0
@sternenseemann
haskellPackages.nix-paths:don't use build tools when cross compiling
966cfdb 
Using build-tools is somewhat flawed since it relies on the host tools
being executable at build time which is not always the case, e.g. when
cross-compiling. The simplest solution (patching being the alternative)
is to simply use the flag that makes nix-paths use PATH at runtime.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Oct 31, 2025
wolfgangwalther
wolfgangwalther approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 31, 2025
@sternenseemann sternenseemann added this pull request to the merge queue Oct 31, 2025
Merged via the queue into NixOS:haskell-updates with commit 7e3e986 Oct 31, 2025
36 of 38 checks passed
@sternenseemann sternenseemann deleted the nix-paths-no-build-tools branch October 31, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@peti peti Awaiting requested review from peti

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sternenseemann @wolfgangwalther