Skip to content

odamex: 0.9.5 -> 11.1.1#457213

Closed
locallycompact wants to merge 1 commit intoNixOS:masterfrom
locallycompact:odamex
Closed

odamex: 0.9.5 -> 11.1.1#457213
locallycompact wants to merge 1 commit intoNixOS:masterfrom
locallycompact:odamex

Conversation

@locallycompact
Copy link
Contributor

@locallycompact locallycompact commented Oct 31, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 31, 2025
@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@iedame
Copy link
Contributor

iedame commented Nov 3, 2025

@iedame
Copy link
Contributor

iedame commented Nov 3, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 457213
Commit: 4557f56daf79b033b33a9de8440bcfca52d04249 (subsequent changes)
Merge: 27578202a10ca1472f28c01d6557e02c379402ac

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/19040092329

x86_64-linux

✅ 1 package built:
  • odamex

aarch64-linux

✅ 1 package built:
  • odamex

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

SuperSandro2000
SuperSandro2000 reviewed Nov 7, 2025
View reviewed changes
pkgs/by-name/od/odamex/package.nix

postPatch = ''
substituteInPlace libraries/cpptrace-lib.cmake \
--replace '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}"' '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}" "-DCPPTRACE_FIND_LIBDWARF_WITH_PKGCONFIG=ON"'
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--replace '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}"' '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}" "-DCPPTRACE_FIND_LIBDWARF_WITH_PKGCONFIG=ON"'
--replace-fail '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}"' '"-DCPPTRACE_USE_EXTERNAL_LIBDWARF=''${USE_EXTERNAL_LIBDWARF}" "-DCPPTRACE_FIND_LIBDWARF_WITH_PKGCONFIG=ON"'

SuperSandro2000
SuperSandro2000 reviewed Nov 7, 2025
View reviewed changes
pkgs/by-name/od/odamex/package.nix
src = fetchurl {
url = "mirror://sourceforge/${pname}/${pname}-src-${version}.tar.bz2";
sha256 = "sha256-WBqO5fWzemw1kYlY192v0nnZkbIEVuWmjWYMy+1ODPQ=";
url = "mirror://sourceforge/${pname}/${pname}-src-${version}.tar.gz";
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = "mirror://sourceforge/${pname}/${pname}-src-${version}.tar.gz";
url = "mirror://sourceforge/odamex/odamex-src-${version}.tar.gz";

this is an anti pattern

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 7, 2025
@keenanweaver
Copy link
Member

keenanweaver commented Nov 7, 2025 •
edited
Loading

Currently doesn't work.

Missing odamex binary, odalaunch returns:

(odalaunch:42237): GLib-GIO-ERROR **: 16:19:01.278: No GSettings schemas are installed on the system
Trace/breakpoint trap      (core dumped) odalaunch
[ble: exit 133]

I'd suggest making the changes from a previous PR: yuria256@40b7c6f

@eljamm eljamm mentioned this pull request Nov 8, 2025
Merged
13 tasks
@Aleksanaa
Copy link
Member

Aleksanaa commented Nov 14, 2025

Superseded by #459626

@Aleksanaa Aleksanaa closed this Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@locallycompact @iedame @keenanweaver @Aleksanaa @SuperSandro2000