aliases: remove hacky workaround for warnings on strings#457057
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Oct 30, 2025
Merged
aliases: remove hacky workaround for warnings on strings#457057wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
This causes confusing eval errors when not using these values (here: `system`) in a string interpolation context. The change will potentially be noisy for nix search. If we want a deprecation period for this attribute instead of just throwing immediately, we will have to accept this, at least temporarily.
13 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes confusing eval errors when not using these values (here:
system) in a string interpolation context.The change will potentially be noisy for nix search. If we want a deprecation period for this attribute instead of just throwing immediately, we will have to accept this, at least temporarily.
Fixes #456527 (comment).
Things done
nix repl. It's a string. A real string.Add a 👍 reaction to pull requests you find important.