Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkgs/by-name/ci/ciscoPacketTracer7/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
buildFHSEnv,
copyDesktopItems,
makeDesktopItem,
libsForQt5,
packetTracerSource ? null,
}:

Expand Down Expand Up @@ -145,5 +146,12 @@ stdenvNoCC.mkDerivation {
];
platforms = [ "x86_64-linux" ];
sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
knownVulnerabilities = [
''
Cisco Packet Tracer 7 ships with qt5 qtwebengine.

${lib.head libsForQt5.qtwebengine.meta.knownVulnerabilities}
''
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually why not

Suggested change
];
]
++ libsForQt5.qtwebengine.meta.knownVulnerabilities;

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it would list those vulnerabilities as separate entries, when they are just one:

       Known issues:                                                                                                                                                                                              
        - Cisco Packet Tracer 8 ships with qt5 qtwebengine.                                                                                                                                                       
                                                                                                                                                                                                                  
        - qt5 qtwebengine is unmaintained upstream since april 2025.                                                                                                                                              
       It is based on chromium 87.0.4280.144, and supposedly patched up to 135.0.7049.95 which is outdated.                                                                                                       
                                                                                                                                                                                                                  
       Security issues are frequently discovered in chromium.                                                                                                                                                     
       The following list of CVEs was fixed in the life cycle of chromium 138 and likely also affects qtwebengine:                                                                                                
       - CVE-2025-8879                                                                                                                                                                                            
       - CVE-2025-8880
       ...

It seems more logical to put them in one, but if this is preferred I'm happy to change it.

};
}
8 changes: 8 additions & 0 deletions pkgs/by-name/ci/ciscoPacketTracer8/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
buildFHSEnv,
copyDesktopItems,
makeDesktopItem,
libsForQt5,
version ? "8.2.2",
packetTracerSource ? null,
}:
Expand Down Expand Up @@ -174,5 +175,12 @@ stdenvNoCC.mkDerivation {
];
platforms = [ "x86_64-linux" ];
sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
knownVulnerabilities = [
''
Cisco Packet Tracer 8 ships with qt5 qtwebengine.

${lib.head libsForQt5.qtwebengine.meta.knownVulnerabilities}
''
];
};
}
Loading