haskell-language-server: Fix build

[maralorn]

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[maralorn]

I have no clue what’s wrong with the CI here …

[wolfgangwalther]

I have no clue what’s wrong with the CI here …

I have no idea either. It happened a week ago or so. I thought I fixed it with automatic retries. Now it appears again. For now, when this happens, the workflow needs to re-run repeatedly. Sometimes a few times until it works :/

[wolfgangwalther]

Now, I didn't test this build, yet, but are you saying that fixing HLS only involves removing lines, not adding a single new one? That's great :D

[maralorn]

Now, I didn't test this build, yet, but are you saying that fixing HLS only involves removing lines, not adding a single new one? That's great :D

Yes. It’s basically just removing fixes for stuff that got upstreamed.

[wolfgangwalther]

Do we need to do the same for the GHC version specific overlays?

[maralorn]

Do we need to do the same for the GHC version specific overlays?

I don’t think so. But I haven’t tested it and my general vibe was to just merge this and see what sticks.

[wolfgangwalther]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 456151
Commit: c270d540baba9e132e3ad52a2e97b23126ad4cf1

---

x86_64-linux

❌ 3 packages failed to build:

• haskell.packages.ghc94.haskell-language-server
• haskell.packages.ghc96.haskell-language-server
• haskell.packages.ghc98.haskell-language-server

✅ 12 packages built:

• haskell-language-server
• haskell.package-list
• haskellPackages.haskell-language-server (haskell.packages.ghc910.haskell-language-server)
• haskell.packages.ghc912.haskell-language-server
• haskellPackages.ghcide
• haskellPackages.ghcide.doc
• haskellPackages.hiedb
• haskellPackages.hiedb.doc
• haskellPackages.hls-plugin-api
• haskellPackages.hls-plugin-api.doc
• haskellPackages.hls-test-utils
• haskellPackages.hls-test-utils.doc

---

Error logs: `x86_64-linux`

haskell.packages.ghc96.haskell-language-server

setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file "haskell-language-server-2.12.0.0/test/wrapper/Main.hs"
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: compileBuildDriverPhase
@nix { "action": "setPhase", "phase": "compileBuildDriverPhase" }
setupCompileFlags: -package-db=/build/tmp.Vg5aqCW3Qd/setup-package.conf.d -threaded
[1 of 2] Compiling Main             ( Setup.hs, /build/tmp.Vg5aqCW3Qd/Main.o )
[2 of 2] Linking Setup
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configureFlags: --verbose --prefix=/nix/store/qvcdzmfn0gsy7yj95v2wkls980landzd-haskell-language-server-2.12.0.0 --libdir=$prefix/lib/$compiler/lib --libsubdir=$abi/$libname --with-gcc=gcc --package-db=/build/tmp.Vg5aqCW3Qd/package.conf.d --ghc-option=-optl=-Wl,-rpath=/nix/store/qvcdzmfn0gsy7yj95v2wkls980landzd-haskell-language-server-2.12.0.0/lib/ghc-9.6.7/lib/haskell-language-server-2.12.0.0 --ghc-option=-j16 --ghc-option=+RTS --ghc-option=-A64M --ghc-option=-RTS --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --enable-executable-dynamic --disable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --enable-split-sections --enable-library-stripping --enable-executable-stripping --extra-lib-dirs=/nix/store/s58723hvjaaq0qs3h61mn64mwp7044wj-ncurses-6.5/lib --extra-lib-dirs=/nix/store/cyw33ds8cfwj1c6740llq1mzk4iinspp-libffi-3.5.2/lib --extra-lib-dirs=/nix/store/9yyfg7f6d9v53cw7rn090d6dfsg3vld0-elfutils-0.193/lib --extra-lib-dirs=/nix/store/sd9c9h940yv36386mvyq2vqmyv80qnsc-gmp-with-cxx-6.3.0/lib --extra-lib-dirs=/nix/store/krmgqvd5cgl3hvlq39blhhwp174gbp97-numactl-2.0.18/lib --extra-lib-dirs=/nix/store/w7w2c8vjik9zzzkwlik09xpzf874ad07-ghc-9.6.7/lib
Using Parsec parser
Configuring haskell-language-server-2.12.0.0...
CallStack (from HasCallStack):
  withMetadata, called at libraries/Cabal/Cabal/src/Distribution/Simple/Utils.hs:368:14 in Cabal-3.10.3.0:Distribution.Simple.Utils
Error: Setup: Encountered missing or private dependencies:
markdown-unlit

haskell.packages.ghc98.haskell-language-server

setting SOURCE_DATE_EPOCH to timestamp 1000000000 of file "haskell-language-server-2.12.0.0/test/wrapper/Main.hs"
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: compileBuildDriverPhase
@nix { "action": "setPhase", "phase": "compileBuildDriverPhase" }
setupCompileFlags: -package-db=/build/tmp.u1764WHrih/setup-package.conf.d -threaded
[1 of 2] Compiling Main             ( Setup.hs, /build/tmp.u1764WHrih/Main.o )
[2 of 2] Linking Setup
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
configureFlags: --verbose --prefix=/nix/store/zijv70w187gd0lakidgghphl952p75ik-haskell-language-server-2.12.0.0 --libdir=$prefix/lib/$compiler/lib --libsubdir=$abi/$libname --with-gcc=gcc --package-db=/build/tmp.u1764WHrih/package.conf.d --ghc-option=-optl=-Wl,-rpath=/nix/store/zijv70w187gd0lakidgghphl952p75ik-haskell-language-server-2.12.0.0/lib/ghc-9.8.4/lib/haskell-language-server-2.12.0.0 --ghc-option=-j16 --ghc-option=+RTS --ghc-option=-A64M --ghc-option=-RTS --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --enable-executable-dynamic --disable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --enable-split-sections --enable-library-stripping --enable-executable-stripping --extra-lib-dirs=/nix/store/s58723hvjaaq0qs3h61mn64mwp7044wj-ncurses-6.5/lib --extra-lib-dirs=/nix/store/cyw33ds8cfwj1c6740llq1mzk4iinspp-libffi-3.5.2/lib --extra-lib-dirs=/nix/store/9yyfg7f6d9v53cw7rn090d6dfsg3vld0-elfutils-0.193/lib --extra-lib-dirs=/nix/store/sd9c9h940yv36386mvyq2vqmyv80qnsc-gmp-with-cxx-6.3.0/lib --extra-lib-dirs=/nix/store/krmgqvd5cgl3hvlq39blhhwp174gbp97-numactl-2.0.18/lib --extra-lib-dirs=/nix/store/djplfvrs3irr54rk1327nlngvh23gl6r-ghc-9.8.4/lib
Using Parsec parser
Configuring haskell-language-server-2.12.0.0...
CallStack (from HasCallStack):
  withMetadata, called at libraries/Cabal/Cabal/src/Distribution/Simple/Utils.hs:368:14 in Cabal-3.10.3.0-a746:Distribution.Simple.Utils
Error: Setup: Encountered missing or private dependencies:
markdown-unlit

[wolfgangwalther]

For GHC 9.4, HLS dropped support. I think we should just mark it as broken there.

[wolfgangwalther]

No objections to merging this right now. Fixing the others here or later both fine by me.

[maralorn]

For GHC 9.4, HLS dropped support. I think we should just mark it as broken there.

We generally put an explicit deprecation error in the according -ghc-*.nix file. Sadly I can’t copy the one from 9.2 because that file is already gone. 😆