{libtransmission_3,transmission_3{,-gtk,-qt,_noSystemd},torrential}: drop#456060
Merged
wolfgangwalther merged 6 commits intoNixOS:masterfrom Oct 30, 2025
Merged
{libtransmission_3,transmission_3{,-gtk,-qt,_noSystemd},torrential}: drop#456060wolfgangwalther merged 6 commits intoNixOS:masterfrom
wolfgangwalther merged 6 commits intoNixOS:masterfrom
Conversation
emilazy
force-pushed
the
push-wpsxnooqlulq
branch
from
8f6cddb to
cf0b476
Compare
Contributor
|
treefmt CI error: diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix
index 6c71d14ee..f93ea0570 100644
--- a/pkgs/top-level/aliases.nix
+++ b/pkgs/top-level/aliases.nix
@@ -2549,7 +2549,6 @@ mapAliases {
tkimg = tclPackages.tkimg; # Added 2024-10-02
tlaplusToolbox = tlaplus-toolbox; # Added 2025-08-21
todiff = throw "'todiff' was removed due to lack of known users"; # Added 2025-01-25
- torrential = throw "torrential was removed, as it requires Transmission 3 which was removed"; # Added 2025-10-27
toil = throw "toil was removed as it was broken and requires obsolete versions of libraries"; # Added 2024-09-22
tokyo-night-gtk = tokyonight-gtk-theme; # Added 2024-01-28
tomcat_connectors = apacheHttpdPackages.mod_jk; # Added 2024-06-07
@@ -2557,6 +2556,7 @@ mapAliases {
tooling-language-server = deputy; # Added 2025-06-22
tor-browser-bundle-bin = tor-browser; # Added 2023-09-23
torq = throw "torq has been removed because the project went closed source"; # Added 2024-11-24
+ torrential = throw "torrential was removed, as it requires Transmission 3 which was removed"; # Added 2025-10-27
torrenttools = throw "torrenttools has been removed due to lack of maintanance upstream"; # Added 2025-04-06
torzu = throw "torzu has been removed from nixpkgs, as it is subject to a DMCA takedown"; # Added 2025-05-12
tracker = lib.warnOnInstantiate "tracker has been renamed to tinysparql" tinysparql; # Added 2024-09-30 |
doronbehar
reviewed
Oct 27, 2025
emilazy
force-pushed
the
push-wpsxnooqlulq
branch
2 times, most recently
from
cd17722 to
22867d5
Compare
emilazy
changed the title
emilazy
force-pushed
the
push-wpsxnooqlulq
branch
3 times, most recently
from
43909db to
7d3004a
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
Author
|
nix-owners
bot
requested review from
bobby285271,
davidak,
philiptaron and
xiorcale
Member
|
|
doronbehar
reviewed
Oct 28, 2025
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
Looks almost perfect to me!
Contributor
There was a problem hiding this comment.
Thank you for the ping! The assertion change does indeed look like black magic, but if it works i won't complain. The tryEval we had before was presumably slow and not much less hacky. Apparmor test still evals. I don't see any obvious issues with that part.
Edit: To clarify, i only looked at the apparmor changes, not the rest of the PR.
Contributor
|
Needs a rebase after #456065. |
nixpkgs-ci
bot
added
the
2.status: merge conflict
The Transmission module adds the package automatically.
I don’t know why setting `--config-dir` breaks the finish script with Transmission 4, but I don’t really feel like spending more time investigating than I already did. It does still respect the passed settings, since we were passing the default location anyway.
We probably shouldn’t block Darwin on the GTK version of Transmission 4 either, but hey…
…drop Unmaintained upstream and it’s been a year since we started migrating to Transmission 4. Let’s not carry networked software from half a decade ago into 25.11.
emilazy
force-pushed
the
push-wpsxnooqlulq
branch
from
7d3004a to
0c3f4b7
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
wolfgangwalther
approved these changes
Oct 28, 2025
Comment on lines
+226
to
+233
| } | ||
| // { | ||
| defaultText = '' | ||
| if lib.versionAtLeast config.system.stateVersion "25.11" then | ||
| pkgs.transmission_4 | ||
| else | ||
| «error message» | ||
| ''; |
Contributor
There was a problem hiding this comment.
I'm not sure we need this additional defaultText, I'd just stick with the default.
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
12.approvals: 2
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unmaintained upstream and it’s been a year since we started migrating to Transmission 4. Let’s not carry networked software from half a decade ago into 25.11.
cc @leona-ya @jopejoe1 for freeze
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.