talloc: Fix linker flags on darwin.#4557
Merged
aristidb merged 1 commit intoNixOS:masterfrom Oct 22, 2014
Merged
Conversation
Before this patch, building talloc on darwin (OS X 10.8.5) results in: gcc -dynamiclib -Wl,-search_paths_first -undefined error -o libtalloc.dylib.2.0.1 ./talloc.o ./libreplace/replace.o ./libreplace/snprintf.o ./libreplace/getpass.o ./libreplace/strptime.o -install_namelibtalloc.dylib.2 gcc: error: unrecognized command line option '-install_namelibtalloc.dylib.2' make: *** [libtalloc.dylib.2.0.1] Error 1 Setting SONAMEFLAG to either "-install_name " (note trailing space), or "-Wl,-install_name," results in a successful build. The latter seems more clear.
aristidb
added a commit
that referenced
this pull request
Oct 22, 2014
talloc: Fix linker flags on darwin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, building talloc on darwin (OS X 10.8.5) results in:
Setting SONAMEFLAG to either "-install_name " (note trailing space), or
"-Wl,-install_name," results in a successful build. The latter seems
more clear.
I haven't yet tested this lib since the package that depends on it is also giving me fits on darwin for unrelated reasons.