Skip to content

doctest: fix static build #455309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alois31 wants to merge 1 commit into from
Closed

doctest: fix static build #455309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkgs/by-name/do/doctest/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ stdenv.mkDerivation rec {

nativeBuildInputs = [ cmake ];

cmakeFlags = lib.optionals stdenv.hostPlatform.isStatic [
(lib.cmakeBool "DOCTEST_WITH_TESTS" false)
];

doCheck = true;
Comment on lines +32 to 36
Copy link
Member

@Aleksanaa Aleksanaa Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cmakeFlags = lib.optionals stdenv.hostPlatform.isStatic [
(lib.cmakeBool "DOCTEST_WITH_TESTS" false)
];
doCheck = true;
cmakeFlags = [
(lib.cmakeBool "DOCTEST_WITH_TESTS" finalAttrs.finalPackage.doCheck)
];
doCheck = !stdenv.hostPlatform.isStatic;

Like this?

Copy link
Contributor Author

@alois31 alois31 Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In staging, as doctest is a mass rebuild.


# Fix the build with LLVM 21 / GCC 15.
Expand Down
Loading