nix-output-monitor: allow pinning a specific Nix version#454982
Open
philiptaron wants to merge 1 commit intoNixOS:masterfrom
Open
nix-output-monitor: allow pinning a specific Nix version#454982philiptaron wants to merge 1 commit intoNixOS:masterfrom
philiptaron wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
I'm interested in using `nom` for `nixos-rebuild`, which wants to do this. In order to avoid the patch breaking on upgrade without someone noticing, it's applied unilaterally, just with do-nothing replacements.
philiptaron
force-pushed
the
nix-output-monitor-set-specific-nix
branch
from
e71889e to
4cd9a77
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
13 tasks
Contributor
Author
|
I've put the motivating PR up at #455383. |
nixpkgs-ci
bot
added
the
2.status: merge-bot eligible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm interested in using
nomfornixos-rebuild, which wants to do this.I tested with
nom --version, which then turns around and callsnix --version.nix-build --expr 'with import ./. { }; nix-output-monitor.override { withPinnedNix = true; nix = lixPackageSets.latest.lix; }'nix-build --expr 'with import ./. { }; nix-output-monitor.override { withPinnedNix = true; nix = nixVersions.nix_2_32; }'nix-build --expr 'with import ./. { }; nix-output-monitor.override { withPinnedNix = true; nix = nixVersions.nix_2_28; }'It's moderately lame to hold a patch for this purpose in Nixpkgs, but this code appears to be quite stable over time in
nix-output-monitor, so I don't feel too bad about it.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.