Skip to content

Revert "Define wrapper env vars as full paths"#45442

Merged
globin merged 3 commits intostagingfrom
revert-wrapper-env-var-path
Aug 21, 2018
Merged

Revert "Define wrapper env vars as full paths"#45442
globin merged 3 commits intostagingfrom
revert-wrapper-env-var-path

Conversation

@matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Aug 21, 2018

This reverts commit 89efc27, reversing
changes made to d0f1102. This is from PR #44767.

This PR had many unintended side effects. It seems prudent to just revert, hopefully making way to do this some time later on when all of the issues are resolved.

@matthewbauer matthewbauer changed the base branch from master to staging August 21, 2018 20:42
@matthewbauer matthewbauer changed the base branch from staging to master August 21, 2018 20:42
@matthewbauer matthewbauer changed the base branch from master to staging August 21, 2018 20:42
@matthewbauer matthewbauer requested review from Ericson2314, dezgeg and vcunat and removed request for Ericson2314, basvandijk, peti and ryantm August 21, 2018 20:42
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Aug 21, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package and removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 21, 2018
@7c6f434c 7c6f434c mentioned this pull request Aug 21, 2018
Closed
9 tasks
@globin globin merged commit f7bc33a into staging Aug 21, 2018
@globin globin deleted the revert-wrapper-env-var-path branch August 21, 2018 23:14
@7c6f434c
Copy link
Member

7c6f434c commented Aug 22, 2018

How much breakage should this be shown to fix on master to be merged to master ahead of the other changes in staging? Or is staging merge including this imminent?

@edolstra edolstra mentioned this pull request Aug 22, 2018
Closed
@vcunat
Copy link
Member

vcunat commented Aug 22, 2018 •
edited
Loading

Rebuild-wise, excluding anything else will probably not help. Stability-wise, I don't know (I haven't looked at most of the other changes).

@vcunat vcunat mentioned this pull request Aug 23, 2018
Closed
@7c6f434c 7c6f434c mentioned this pull request Aug 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthewbauer @7c6f434c @vcunat @Ericson2314 @globin @GrahamcOfBorg