Skip to content

android-udev-rules: drop#454366

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
timschumi:drop-android-udev-rules
Oct 23, 2025
Merged

android-udev-rules: drop#454366
JohnRTitor merged 1 commit intoNixOS:masterfrom
timschumi:drop-android-udev-rules

Conversation

@timschumi
Copy link
Member

@timschumi timschumi commented Oct 21, 2025 •
edited
Loading

As of systemd 258 (systemd/systemd@edc4920) adb and fastboot connections are handled by a built-in uaccess rule, so a dedicated package with hardcoded ID-based udev rules is no longer needed.

Drop the android-udev-rules package and related mentions of the adbusers group, which is also no longer used.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@timschumi
android-udev-rules: drop
c06ad37 
As of systemd 258 adb and fastboot connections are handled by a built-in
uaccess rule, so a dedicated package with hardcoded ID-based udev rules
is no longer needed.

Drop the android-udev-rules package and related mentions of the adbusers
group, which is also no longer used.
@timschumi timschumi force-pushed the drop-android-udev-rules branch from b479de5 to c06ad37 Compare October 21, 2025 22:13
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 21, 2025
RossComputerGuy
RossComputerGuy approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's wait until #427968 hits unstable (https://nixpk.gs/pr-tracker.html?pr=427968) before merging.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 22, 2025
@JohnRTitor
Copy link
Member

JohnRTitor commented Oct 22, 2025 •
edited
Loading

We are fine with merging it into master though. Because as far as I can see new systemd is already in master.

@timschumi
Copy link
Member Author

timschumi commented Oct 22, 2025

Because as far as I can see new systemd is already in master.

It is, I specifically waited on the current staging-next cycle to file this PR.

@timschumi
Copy link
Member Author

timschumi commented Oct 22, 2025

On another note

cc @Mic92 as the maintainer of the ADB module
cc @PassiveLemon @Pandapip1 @Scrumplex @txkyel as the maintainers of envision and wivrn, I don't have any VR hardware to test this, only normal phones and tablets.

@RossComputerGuy
Copy link
Member

RossComputerGuy commented Oct 22, 2025

We are fine with merging it into master though. Because as far as I can see new systemd is already in master.

Ah, when I was looking at the PR, it wasn't there yet.

@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit a9440ea Oct 23, 2025
39 of 42 checks passed
@timschumi timschumi deleted the drop-android-udev-rules branch October 23, 2025 10:14
tlvince added a commit to tlvince/nixos-config that referenced this pull request Oct 23, 2025
@tlvince
fix(framework): adb auth built-in to systemd v258
80fe834 
NixOS/nixpkgs#454366
reality-exe pushed a commit to reality-exe/lemonake that referenced this pull request Oct 29, 2025
drop android-udev-rules
a15b247 
`udev.packages = with pkgs; [ android-udev-rules ];` is no-longer
needed. See NixOS/nixpkgs#454366
@reality-exe reality-exe mentioned this pull request Oct 29, 2025
Merged
dixslyf added a commit to dixslyf/dotfiles that referenced this pull request Nov 1, 2025
@dixslyf
fix(nixos/alpha): drop android-udev-rules
e79b742 
No longer exists. See NixOS/nixpkgs#454366.
oxalica added a commit to oxalica/nixos-config that referenced this pull request Jan 9, 2026
@oxalica
flake: update and move adb to user packages
14f7f4a 
- `programs.adb.enable` is superseded by systemd udev rules.

  See: <NixOS/nixpkgs#454366>
sarcasticadmin added a commit to sarcasticadmin/systems that referenced this pull request Jan 30, 2026
@sarcasticadmin
treewide: android-udev-rules has been removed
795ea77 
adb and fastboot connections are handled by a built-in uaccess rule,
so a dedicated package with hardcoded ID-based udev rules is no longer needed:

  NixOS/nixpkgs#454366
sarcasticadmin added a commit to sarcasticadmin/systems that referenced this pull request Jan 30, 2026
@sarcasticadmin
treewide: android-udev-rules has been removed
f3a3a2f 
adb and fastboot connections are handled by a built-in uaccess rule,
so a dedicated package with hardcoded ID-based udev rules is no longer needed:

  NixOS/nixpkgs#454366
rvolosatovs added a commit to rvolosatovs/nixelium that referenced this pull request Feb 25, 2026
@rvolosatovs
remove android-udev-rules
40479a5 
NixOS/nixpkgs#454366

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs added a commit to rvolosatovs/nixelium that referenced this pull request Feb 25, 2026
@rvolosatovs
remove android-udev-rules
7747310 
NixOS/nixpkgs#454366

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

@adrian-gierakowski adrian-gierakowski Awaiting requested review from adrian-gierakowski

@numinit numinit Awaiting requested review from numinit

@hadilq hadilq Awaiting requested review from hadilq

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timschumi @JohnRTitor @RossComputerGuy