Skip to content

dprint-plugins: update all plugins#453928

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
phanirithvij:dprint-plugins-old
Oct 23, 2025
Merged

dprint-plugins: update all plugins#453928
wolfgangwalther merged 1 commit intoNixOS:masterfrom
phanirithvij:dprint-plugins-old

Conversation

@phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Oct 20, 2025 •
edited
Loading

There was an issue with the update script preventing some packages from getting updated. Fixed it and updated all the plugins.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Oct 20, 2025
@nix-owners nix-owners bot requested review from kachick and khrj October 20, 2025 18:00
@phanirithvij
Copy link
Member Author

phanirithvij commented Oct 20, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453928

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/18660499758

x86_64-linux

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

aarch64-linux

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

x86_64-darwin (sandbox = true)

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

aarch64-darwin (sandbox = true)

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

kachick

This comment was marked as resolved.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 21, 2025
kachick
kachick reviewed Oct 21, 2025
View reviewed changes
kachick
kachick approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pure mode appears to be working on my local now. Thank you for the refinement. 👍

(CI error seems a temporal one)

wolfgangwalther
wolfgangwalther reviewed Oct 22, 2025
View reviewed changes
pkgs/by-name/dp/dprint/plugins/update-plugins.py Outdated
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -i python -p nix 'python3.withPackages (pp: [ pp.requests ])'
#!nix-shell --pure -i python3 -p nix cacert nixfmt-rfc-style 'python3.withPackages (ps: [ ps.requests ])'
Copy link
Contributor

@wolfgangwalther wolfgangwalther Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed nixfmt from update script shebangs on purpose, because this is not sufficient in the general case.

You are expected to be in a nix-shell session with treefmt / nixfmt (with the correct configuration!) available, to run update scripts.

See #433588 and the related PRs.

Suggested change
#!nix-shell --pure -i python3 -p nix cacert nixfmt-rfc-style 'python3.withPackages (ps: [ ps.requests ])'
#!nix-shell --pure -i python3 -p nix cacert 'python3.withPackages (ps: [ ps.requests ])'

Copy link
Contributor

@wolfgangwalther wolfgangwalther Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(although I am not sure how this interacts with r-ryantm's auto-updates, tbh...)

Copy link
Member

@kachick kachick Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the --pure flag here?

> nix-shell maintainers/scripts/update.nix --argstr package dprint-plugins.g-plane-pretty_yaml

Going to be running update for following packages:
 - g-plane-pretty_yaml-0.5.1

Press Enter key to continue...

Running update for:
Enqueuing group of 1 packages
 - g-plane-pretty_yaml-0.5.1: UPDATING ...
 - g-plane-pretty_yaml-0.5.1: ERROR

--- SHOWING ERROR LOG FOR g-plane-pretty_yaml-0.5.1 ----------------------

path is '/nix/store/j9k82k78jpb2jcdk38zqd4m96fz0gafk-typescript-0.95.11.wasm'
/nix/store/cfqbabpc7xwg8akbcchqbq3cai6qq2vs-bash-5.2p37/bin/sh: line 1: nixfmt: command not found
error: writing to file: Broken pipe
Traceback (most recent call last):

Copy link
Member Author

@phanirithvij phanirithvij Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, removing nixfmt from the update script will not fix the issue the current pr is trying to address.

Because I don't see why gplane* plugins in the dprint plugins folder haven't received updates via r-ryantm apart from missing nixfmt.

Copy link
Member Author

@phanirithvij phanirithvij Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be merged for now? I will manually update these from now on if auto-updates don't work. Or maybe raise an issue at r-ryantm's repo.

Copy link
Member

@kachick kachick Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why gplane* plugins in the dprint plugins folder haven't received updates via r-ryantm

I suspect the condition is whether Replogy has another repository, like AUR, for the plugin.

https://repology.org/projects/?search=&maintainer=&category=dprint-plugins&inrepo=nix_unstable&notinrepo=&repos=&families=&repos_newest=&families_newest=

The blue mark means nixpkgs is the only one repository.

image

https://nixpkgs-update-logs.nix-community.org/

image

@phanirithvij @kachick @wolfgangwalther
dprint-plugins: update all plugins
cad32a2 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>

dprint-plugins: fix update script

Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>
Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453928
Commit: cad32a24812b17a574b1ce57a7885dd4459f9f4a

x86_64-linux

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

aarch64-linux

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

x86_64-darwin

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

aarch64-darwin

✅ 6 packages built:
  • dprint-plugins.dprint-plugin-dockerfile
  • dprint-plugins.dprint-plugin-ruff
  • dprint-plugins.g-plane-malva
  • dprint-plugins.g-plane-markup_fmt
  • dprint-plugins.g-plane-pretty_graphql
  • dprint-plugins.g-plane-pretty_yaml

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit afe4c84 Oct 23, 2025
27 of 30 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 23, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-453928-to-release-25.05 origin/release-25.05
cd .worktree/backport-453928-to-release-25.05
git switch --create backport-453928-to-release-25.05
git cherry-pick -x cad32a24812b17a574b1ce57a7885dd4459f9f4a

@phanirithvij phanirithvij deleted the dprint-plugins-old branch October 23, 2025 10:59
@phanirithvij phanirithvij mentioned this pull request Oct 23, 2025
Merged
1 task
@phanirithvij phanirithvij added 8.has: port to stable This PR already has a backport to the stable release. and removed backport release-25.05 labels Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@khrj khrj Awaiting requested review from khrj

+1 more reviewer

@kachick kachick kachick approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phanirithvij @wolfgangwalther @kachick