dockerTools: Replace bashInteractive with bash#453912
Conversation
|
I don't know how to retrigger the failed build checks. |
|
Not seeing the usual buttons on the jobs in the Checks tab either (I think job failures were due to the AWS us-east-1 outage). Not sure if we're missing permissions or something. |
bash has been interactive by default since this PR [1] was merged. This commit simplifies dockerTools given that there is now no distinction between bash and bashInteractive. * [1] NixOS#379368 Co-authored-by: commiterate <111539270+commiterate@users.noreply.github.com> Signed-off-by: Joel Holdsworth <joel@airwebreathe.org.uk>
|
I don't see buttons either. Never mind. I just re-pushed the branch with a trivial mod. |
|
@roberth would you be able to take a look at this? This PR and #453923 are part of an effort to break #387173 into manageable atomic commits. The remaining commits are blocked by these PRs. I hoped that dividing the work into smaller PRs would make it easier to get these changes reviewed, but it seems this approach has also stalled. Please let me know if there's anything I can do to help get these changes through the review process. |
bashhas been interactive by default since this PR was merged. This commit simplifiesdockerToolsgiven that there is now no distinction betweenbashandbashInteractive.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.