Skip to content

haskellPackages: _ prefix attribute names that would need quoting#453366

Merged
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:hs-prefixed-attrs
Nov 26, 2025
Merged

haskellPackages: _ prefix attribute names that would need quoting#453366
sternenseemann merged 2 commits intoNixOS:haskell-updatesfrom
sternenseemann:hs-prefixed-attrs

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Oct 19, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@sternenseemann sternenseemann mentioned this pull request Oct 19, 2025
Merged
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Oct 19, 2025
wolfgangwalther
wolfgangwalther reviewed Oct 19, 2025
View reviewed changes
@sternenseemann
Copy link
Member Author

sternenseemann commented Oct 22, 2025

It seems to me that we ideally merge this together with an update to cabal2nix that makes it also generate function arguments in this scheme. I'm currently chipping away at this.

First, I need to release language-nix 2.3.0 for which I'm in the process of expanding test coverage which also entails fixing some bugs, but I've got the bulk of the work done (locally), I think.

After that, we can release cabal2nix for which I don't see many blockers except finalizing changelogs and merging the attribute mangling PR.

@sternenseemann
Copy link
Member Author

sternenseemann commented Nov 20, 2025 •
edited
Loading

  • Add warnings on unstable
  • Add compat aliases for 25.11 and 25.05
  • (soon) release a new cabal2nix version

@sternenseemann
haskellPackages.cabal2nix-unstable: 2025-11-11 -> 2025-11-20
5a86e3d 
Also run Nix based test cases of the language-nix test suite.
@sternenseemann sternenseemann marked this pull request as ready for review November 24, 2025 11:18
wolfgangwalther
wolfgangwalther reviewed Nov 24, 2025
View reviewed changes
pkgs/development/haskell-modules/configuration-nix.nix
Comment on lines +1534 to +1536
# Cabal doesn't allow us to properly specify the test dependency
# on nix-instantiate(1). Even though we're just evaluating pure code,
# it absolutely wants to write to disk.
Copy link
Contributor

@wolfgangwalther wolfgangwalther Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can nix-instantiate --readonly-mode help here?

(didn't check whether we're already using it)

Copy link
Member Author

@sternenseemann sternenseemann Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, but nix-instantiate still tries to create profiles, so I didn't bother adding it. I mean, --readonly-mode just tells it not to write anything to the store when it would have to, but this is never the case in the test suite.

@sternenseemann
haskellPackages: _ prefix attribute names that would need quoting
8780e5b 
In order not to break downstream expressions that (manually) introduced
dependencies on now renamed attributes, add aliases (with proper
warnings about the renames) for all attributes that were previously part
of Nixpkgs, but have been renamed with this change.
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 25, 2025
@sternenseemann sternenseemann added this pull request to the merge queue Nov 26, 2025
Merged via the queue into NixOS:haskell-updates with commit d739a50 Nov 26, 2025
30 of 32 checks passed
@sternenseemann sternenseemann deleted the hs-prefixed-attrs branch November 26, 2025 09:43
@trofi
Copy link
Contributor

trofi commented Nov 30, 2025

Caused minor eval failure in staging. Proposed a trivial fix as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sternenseemann @trofi @wolfgangwalther