balsa: update to webkitgtk_4_1#453331
Conversation
|
LordGrimmauld
left a comment
There was a problem hiding this comment.
webkitgtk is being found, according to meson log, both x86-64-linux and aarch64-linux:
Run-time dependency webkit2gtk-4.1 found: YES 2.50.1
The app does start, though i did not test whether it works properly (i did not want to give it an actual email).
Build succeeds at least on linux. Meta says this package supposedly supports darwin too, yet webkitgtk (both 4.0 and 4.1 abi) is unavailable on darwin. A Mac-port does exist (see https://ports.macports.org/port/balsa/details/), but the solution there is to just build webkitgtk for mac too. Maybe it makes sense to adjust the meta to linux-only? Not sure.
Diff looks good though, this does add webkitgtk back indeed :)
Update to webkitgtk_4_1 after #450065
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.