Skip to content

balsa: update to webkitgtk_4_1#453331

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
timon-schelling:fix-balsa
Oct 19, 2025
Merged

balsa: update to webkitgtk_4_1#453331
LordGrimmauld merged 1 commit intoNixOS:masterfrom
timon-schelling:fix-balsa

Conversation

@timon-schelling
Copy link
Member

Update to webkitgtk_4_1 after #450065

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 18, 2025
@timon-schelling
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 453331
Commit: c885e8978ac1374b34bad478beda621567e4c430 (subsequent changes)
Merge: 8cfb257ae97fc221eaa430448012946ab21812b4

Logs: https://github.com/timon-schelling/run-nixpkgs-review/actions/runs/18621231055


x86_64-linux

✅ 1 package built:
  • balsa

aarch64-linux

✅ 1 package built:
  • balsa

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@timon-schelling timon-schelling marked this pull request as ready for review October 18, 2025 21:37
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 18, 2025
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webkitgtk is being found, according to meson log, both x86-64-linux and aarch64-linux:

Run-time dependency webkit2gtk-4.1 found: YES 2.50.1

The app does start, though i did not test whether it works properly (i did not want to give it an actual email).

Build succeeds at least on linux. Meta says this package supposedly supports darwin too, yet webkitgtk (both 4.0 and 4.1 abi) is unavailable on darwin. A Mac-port does exist (see https://ports.macports.org/port/balsa/details/), but the solution there is to just build webkitgtk for mac too. Maybe it makes sense to adjust the meta to linux-only? Not sure.

Diff looks good though, this does add webkitgtk back indeed :)

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Oct 19, 2025
Merged via the queue into NixOS:master with commit f8faf45 Oct 19, 2025
33 of 36 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants