crystal_1_18: init at 1.18.2 by straight-shoota · Pull Request #453209 · NixOS/nixpkgs

straight-shoota · 2025-10-18T12:23:53Z

https://github.com/crystal-lang/crystal/blob/release/1.18/CHANGELOG.md

Things done

Add a 👍 reaction to pull requests you find important.

straight-shoota · 2025-10-18T16:46:22Z

The failures in ameba and blahaj seem to be errors in the test cases themselves. They expect specific ANSI sequences for colourization, but that has changed a little bit in 1.18.
The builds themselves should be fine, though.

The failure in invidious looks like a regression in 1.18 (tracked in crystal-lang/crystal#16230).

The latter should be fixed shortly with a new patch release (1.18.2), but the former two require changes in the upstream projects to be released, or fixing/disabling the failing specs.

straight-shoota · 2025-10-21T19:45:16Z

I tried running nixpkgs-review but it crashed my system 😞 Probably an issue with WSL.

kachick · 2025-10-22T11:17:29Z

ahk_x11 failure seems not related to this PR. It failed in last ran of hydra.

> hydra-check ahk_x11
Build Status for nixpkgs.ahk_x11.x86_64-linux on jobset nixos/trunk-combined
https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.ahk_x11.x86_64-linux
✖ (Failed)     ahk_x11-1.0.6                      2025-10-21  https://hydra.nixos.org/build/310362870
✔              ahk_x11-1.0.6                      2025-10-05  https://hydra.nixos.org/build/308802428
✔              ahk_x11-1.0.6                      2025-09-17  https://hydra.nixos.org/build/307642986
✔              ahk_x11-1.0.5-unstable-2025-09-04  2025-09-11  https://hydra.nixos.org/build/306880442
✔              ahk_x11-1.0.5-unstable-2025-09-04  2025-09-08  https://hydra.nixos.org/build/306853546
✔              ahk_x11-1.0.4-unstable-2025-01-30  2025-08-25  https://hydra.nixos.org/build/305559811
✔              ahk_x11-1.0.4-unstable-2025-01-30  2025-07-27  https://hydra.nixos.org/build/303338672
✔              ahk_x11-1.0.4-unstable-2025-01-30  2025-07-13  https://hydra.nixos.org/build/302366243
⏹ (Cancelled)  ahk_x11-1.0.4-unstable-2025-01-30  2025-07-13  https://hydra.nixos.org/build/302270034
✔              ahk_x11-1.0.4-unstable-2025-01-30  2025-06-18  https://hydra.nixos.org/build/300560069

Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>

pkgs/by-name/in/invidious/package.nix

Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>

kachick

I do not think these nixpkgs-review failures relate to the changes in this PR.

The oq failure might be due to a flaky test.
The ahk_x11 failure is already present in master.

While the following updates would be beneficial, I will defer these topics to the package maintainers and committers:

Add comments to the packages to explain why the Crystal dependency was pinned to an older version.
Adjust the commit history to follow conventions, or squash the commits.

Otherwise, LGTM 👍

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453209
Commit: 78021c7da86d183b3ed85bda08c57e04151bc4c6

`x86_64-linux`

❌ 1 package failed to build:

ahk_x11

✅ 22 packages built:

ameba
ameba-ls
amqpcat
blahaj
collision
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
rtfm
shards
thicket
tmuxPlugins.fingers

Error logs: `x86_64-linux`

ahk_x11

warn - Gio::ActionEntry padding field - Unknown conversion to crystal for fixed size array.
warn - Gio::DBusInterfaceVTable padding field - Unknown conversion to crystal for fixed size array.
warn - Gio::DBusSubtreeVTable padding field - Unknown conversion to crystal for fixed size array.
warn - gdk_pixbuf_get_options - Unknown conversion to crystal for GHash
warn - Gdk - WMDecoration::All (0x1) doesn't have all possible bits set (0x7f).
warn - Gdk - WMFunction::All (0x1) doesn't have all possible bits set (0x3f).
info - Gtk - No binding config found for Atk-1.0.
warn - Settings#color-hash - Unknown conversion to crystal for GHash
info - Atspi - No binding config found for DBus-1.0.
warn - Atspi - Cache::All (0x3fffffff) doesn't have all possible bits set (0x7fffffff).
warn - atspi_accessible_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_document_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_attribute_run - Unknown conversion to crystal for GHash
warn - atspi_text_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_default_attributes - Unknown conversion to crystal for GHash
syntax error in './harf_buzz-0.0/harf_buzz.cr:7846:20': can't use variable name 'glyphs_before' inside assignment to variable 'glyphs_before'
fatal - Error formating generated files at '/build/source/lib/gi-crystal/src/auto'.
make[1]: *** [Makefile:63: lib/configured] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:32: bin/ahk_x11] Error 2

`aarch64-linux`

❌ 2 packages failed to build:

ahk_x11
oq

✅ 21 packages built:

ameba
ameba-ls
amqpcat
blahaj
collision
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
rtfm
shards
thicket
tmuxPlugins.fingers

Error logs: `aarch64-linux`

ahk_x11

warn - g_hash_table_ref - Unknown conversion to crystal for GHash
info - HarfBuzz - No binding config found for freetype2-2.0.
warn - HarfBuzz - Interface constant not supported.
info - Notify - No binding config found for GdkPixbuf-2.0.
info - GdkPixbuf - No binding config found for GModule-2.0.
warn - gdk_pixbuf_get_options - Unknown conversion to crystal for GHash
warn - g_cancellable_connect - Callback without user_data!
warn - Gio::ActionEntry padding field - Unknown conversion to crystal for fixed size array.
warn - Gio::DBusInterfaceVTable padding field - Unknown conversion to crystal for fixed size array.
warn - Gio::DBusSubtreeVTable padding field - Unknown conversion to crystal for fixed size array.
info - Gtk - No binding config found for Atk-1.0.
info - gtk_cairo_should_draw_window - No binding config found for cairo-1.0.
warn - Settings#color-hash - Unknown conversion to crystal for GHash
warn - Gdk - WMDecoration::All (0x1) doesn't have all possible bits set (0x7f).
warn - Gdk - WMFunction::All (0x1) doesn't have all possible bits set (0x3f).
syntax error in './harf_buzz-0.0/harf_buzz.cr:7846:20': can't use variable name 'glyphs_before' inside assignment to variable 'glyphs_before'
fatal - Error formating generated files at '/build/source/lib/gi-crystal/src/auto'.
make[1]: *** [Makefile:63: lib/configured] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:32: bin/ahk_x11] Error 2

oq

from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/crystal/event_loop/polling.cr:391 in 'write' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/crystal/system/file_descriptor.cr:39:5 in 'system_write' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/io/file_descriptor.cr:335:16 in 'unbuffered_write' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/io/buffered.cr:147:14 in 'write' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/io.cr:1179:7 in 'copy' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/process.cr:434:7 in 'copy_io' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/process.cr:430:11 in 'copy_io:close_dst' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/process.cr:345:15 in '->' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/fiber.cr:170:11 in 'run' from /nix/store/77sdlmh5n7xlgskbfrdmwvci7c33355i-crystal-1.18.2-lib/crystal/fiber.cr:105:3 in '->' from ???

Finished in 800.18 milliseconds
199 examples, 0 failures, 2 errors, 2 pending

Failed examples:

crystal spec spec/oq_spec.cr:293 # OQ with an invalid output format should return the error and correct exit code
crystal spec spec/converters/xml_spec.cr:367 # OQ::Converters::XML .deserialize Object with namespaces without --xmlns with --xml-namespace-alias should error

`aarch64-darwin`

✅ 20 packages built:

ameba
ameba-ls
amqpcat
blahaj
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
shards
thicket
tmuxPlugins.fingers

GaetanLepage · 2025-10-30T12:50:04Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 453209
Commit: 78021c7da86d183b3ed85bda08c57e04151bc4c6

`x86_64-linux`

❌ 1 package failed to build:

ahk_x11

✅ 22 packages built:

ameba
ameba-ls
amqpcat
blahaj
collision
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
rtfm
shards
thicket
tmuxPlugins.fingers

`aarch64-linux`

❌ 1 package failed to build:

ahk_x11

✅ 22 packages built:

ameba
ameba-ls
amqpcat
blahaj
collision
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
rtfm
shards
thicket
tmuxPlugins.fingers

`x86_64-darwin`

✅ 20 packages built:

ameba
ameba-ls
amqpcat
blahaj
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
shards
thicket
tmuxPlugins.fingers

`aarch64-darwin`

✅ 20 packages built:

ameba
ameba-ls
amqpcat
blahaj
coverage-reporter
crystal (crystal_1_18)
crystal.bin (crystal_1_18.bin)
crystal.lib (crystal_1_18.lib)
crystal2nix
crystalline
gi-crystal
icr
invidious
kakoune-cr
lucky-cli
mint
oq
shards
thicket
tmuxPlugins.fingers

Error logs: `x86_64-linux`

ahk_x11

warn - Gio::DBusSubtreeVTable padding field - Unknown conversion to crystal for fixed size array.
info - Notify - No binding config found for GdkPixbuf-2.0.
warn - gdk_pixbuf_get_options - Unknown conversion to crystal for GHash
info - GdkX11 - No binding config found for cairo-1.0.
warn - Gdk - WMDecoration::All (0x1) doesn't have all possible bits set (0x7f).
warn - Gdk - WMFunction::All (0x1) doesn't have all possible bits set (0x3f).
info - Gtk - No binding config found for Atk-1.0.
warn - Settings#color-hash - Unknown conversion to crystal for GHash
info - Atspi - No binding config found for DBus-1.0.
warn - Atspi - Cache::All (0x3fffffff) doesn't have all possible bits set (0x7fffffff).
warn - atspi_accessible_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_document_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_attribute_run - Unknown conversion to crystal for GHash
warn - atspi_text_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_default_attributes - Unknown conversion to crystal for GHash
syntax error in './harf_buzz-0.0/harf_buzz.cr:7846:20': can't use variable name 'glyphs_before' inside assignment to variable 'glyphs_before'
fatal - Error formating generated files at '/build/source/lib/gi-crystal/src/auto'.
make[1]: *** [Makefile:63: lib/configured] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:32: bin/ahk_x11] Error 2

Error logs: `aarch64-linux`

ahk_x11

warn - g_hash_table_ref - Unknown conversion to crystal for GHash
info - HarfBuzz - No binding config found for freetype2-2.0.
warn - HarfBuzz - Interface constant not supported.
info - GdkX11 - No binding config found for cairo-1.0.
warn - Gdk - WMDecoration::All (0x1) doesn't have all possible bits set (0x7f).
warn - Gdk - WMFunction::All (0x1) doesn't have all possible bits set (0x3f).
info - Gtk - No binding config found for Atk-1.0.
warn - Settings#color-hash - Unknown conversion to crystal for GHash
info - Atspi - No binding config found for DBus-1.0.
warn - Atspi - Cache::All (0x3fffffff) doesn't have all possible bits set (0x7fffffff).
warn - atspi_accessible_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_document_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_attribute_run - Unknown conversion to crystal for GHash
warn - atspi_text_get_attributes - Unknown conversion to crystal for GHash
warn - atspi_text_get_default_attributes - Unknown conversion to crystal for GHash
syntax error in './harf_buzz-0.0/harf_buzz.cr:7846:20': can't use variable name 'glyphs_before' inside assignment to variable 'glyphs_before'
fatal - Error formating generated files at '/build/source/lib/gi-crystal/src/auto'.
make[1]: *** [Makefile:63: lib/configured] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:32: bin/ahk_x11] Error 2

crystal_1_18: init at 1.18.1

b5012be

nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 6.topic: crystal Programming language - https://crystal-lang.org/ labels Oct 18, 2025

nix-owners bot requested review from davy-tw, donovanglover, manveru and peterhoeg October 18, 2025 12:29

This comment was marked as outdated.

Sign in to view

Add to all-packages.nix

757a78e

straight-shoota marked this pull request as draft October 18, 2025 22:07

This comment was marked as resolved.

Sign in to view

straight-shoota added 2 commits October 21, 2025 18:40

Pin ameba and blahaj to crystal_1_17

a1d3ffe

Crystal 1.18.2

436f350

straight-shoota changed the title ~~crystal_1_18: init at 1.18.1~~ crystal_1_18: init at 1.18.2 Oct 21, 2025

straight-shoota marked this pull request as ready for review October 21, 2025 19:44

This comment was marked as outdated.

Sign in to view

Pin invidious to crystal_1_17

614a43b

nix-owners bot requested review from 999eagle, Aleksanaa, GaetanLepage, cafkafk and sbruder October 22, 2025 09:44

This comment was marked as outdated.

Sign in to view

Update pkgs/by-name/in/invidious/package.nix

3c916f4

Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>

kachick reviewed Oct 22, 2025

View reviewed changes

pkgs/by-name/in/invidious/package.nix Outdated Show resolved Hide resolved

Update pkgs/by-name/in/invidious/package.nix

78021c7

Co-authored-by: Kenichi Kamiya <kachick1@gmail.com>

kachick approved these changes Oct 22, 2025

View reviewed changes

nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2025

GaetanLepage approved these changes Oct 30, 2025

View reviewed changes

GaetanLepage added this pull request to the merge queue Oct 30, 2025

Merged via the queue into NixOS:master with commit 7db9cf0 Oct 30, 2025
30 of 31 checks passed

straight-shoota deleted the feat/crystal_1_18 branch October 30, 2025 16:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

crystal_1_18: init at 1.18.2#453209

crystal_1_18: init at 1.18.2#453209
GaetanLepage merged 7 commits intoNixOS:masterfrom
straight-shoota:feat/crystal_1_18

straight-shoota commented Oct 18, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

straight-shoota commented Oct 18, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

straight-shoota commented Oct 21, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

kachick commented Oct 22, 2025

Uh oh!

Uh oh!

kachick left a comment

Uh oh!

GaetanLepage commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

straight-shoota commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

straight-shoota commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

straight-shoota commented Oct 21, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

kachick commented Oct 22, 2025

Uh oh!

Uh oh!

kachick left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

aarch64-linux

aarch64-darwin

Uh oh!

GaetanLepage commented Oct 30, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

straight-shoota commented Oct 18, 2025 •

edited

Loading

straight-shoota commented Oct 18, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`