Skip to content

httplib: added pkgconfig#452456

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
fzakaria:fzakaria/httplib-pkgconfig
Oct 16, 2025
Merged

httplib: added pkgconfig#452456
JohnRTitor merged 1 commit intoNixOS:masterfrom
fzakaria:fzakaria/httplib-pkgconfig

Conversation

@fzakaria
Copy link
Contributor

@fzakaria fzakaria commented Oct 16, 2025 •
edited
Loading

Added support for pkgconfig.

cat  result/lib/pkgconfig/httplib.pc
includedir=/nix/store/8zn99d7khz7959p0yzv43y090glbdjrw-httplib-0.19.0/include
prefix=/nix/store/8zn99d7khz7959p0yzv43y090glbdjrw-httplib-0.19.0

Cflags: -I/nix/store/8zn99d7khz7959p0yzv43y090glbdjrw-httplib-0.19.0/include
Description: C++ header-only HTTP/HTTPS server and client library
Name: httplib
Version: 0.19.0

I added myself as maintainer since it had none.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 16, 2025
@fzakaria fzakaria mentioned this pull request Oct 16, 2025
Open
@MatthewCroughan
Copy link
Contributor

MatthewCroughan commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452456 --package httplib
Commit: 381bc4e41cf35a75f94f41c2c9ed7c3c7c55c9ef

aarch64-linux

✅ 1 package built:
  • httplib

@MatthewCroughan
Copy link
Contributor

MatthewCroughan commented Oct 16, 2025 •
edited
Loading

@fzakaria what other derivation wants to consume these pkg-config output files, so I can test the build of those?

JohnRTitor
JohnRTitor reviewed Oct 16, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 16, 2025
@fzakaria
Copy link
Contributor Author

fzakaria commented Oct 16, 2025

@MatthewCroughan I have been using this change in NixOS/nix#14266 effectively that you can audit.

@fzakaria fzakaria force-pushed the fzakaria/httplib-pkgconfig branch from 8126fa4 to b150f20 Compare October 16, 2025 16:44
@fzakaria fzakaria requested a review from JohnRTitor October 16, 2025 16:44
JohnRTitor
JohnRTitor reviewed Oct 16, 2025
View reviewed changes
@fzakaria @JohnRTitor
httplib: added pkgconfig
cf387b1 
nix: update to inherit

Co-authored-by: Masum Reza <50095635+JohnRTitor@users.noreply.github.com>
@fzakaria fzakaria force-pushed the fzakaria/httplib-pkgconfig branch from b150f20 to cf387b1 Compare October 16, 2025 17:06
@fzakaria fzakaria requested a review from JohnRTitor October 16, 2025 17:06
@fzakaria
Copy link
Contributor Author

fzakaria commented Oct 16, 2025

I modeled it after https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/st/stb/package.nix

@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 16, 2025
@MatthewCroughan
Copy link
Contributor

MatthewCroughan commented Oct 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 452456
Commit: b150f20223c614f7f480063c5405019ada5aa7f8

aarch64-linux

✅ 6 packages built:
  • azahar
  • descent3
  • descent3-unwrapped
  • httplib
  • nixpkgs-manual
  • zeal

Merged via the queue into NixOS:master with commit 849d024 Oct 16, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnRTitor JohnRTitor Awaiting requested review from JohnRTitor

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fzakaria @MatthewCroughan @JohnRTitor