Skip to content

python3Packages.correctionlib: reduce churn on compiler updates#451855

Merged
veprbl merged 1 commit intoNixOS:masterfrom
sarahec:correctionlib-deprecation-ok
Oct 22, 2025
Merged

python3Packages.correctionlib: reduce churn on compiler updates#451855
veprbl merged 1 commit intoNixOS:masterfrom
sarahec:correctionlib-deprecation-ok

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented Oct 14, 2025 •
edited
Loading

Removed -WError along with spammy warnings to prevent rework when new compiler releases come out.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 14, 2025
@nix-owners nix-owners bot requested a review from veprbl October 14, 2025 04:04
@sarahec
Copy link
Contributor Author

sarahec commented Oct 14, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451855
Commit: 9c56f0f314c16849f438cd76bb3870df280f0450

aarch64-darwin

❌ 4 packages failed to build:
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
✅ 4 packages built:
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist
  • python313Packages.correctionlib
  • python313Packages.correctionlib.dist

Notes

python3Packages.coffea depends on python3Packages.dask-awkward which is known to be broken (and not immediately repairable due to issues within the dask project itself).

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 14, 2025
@iedame iedame mentioned this pull request Oct 18, 2025
Closed
13 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 19, 2025 •
edited
Loading

We should drop Werror to reduce churn on compiler updates https://github.com/search?q=repo%3Acms-nanoAOD%2Fcorrectionlib%20werror&type=code

Also the wall wextra and wpedenatic should be removed as they probably spam the log with warnings.

@sarahec sarahec force-pushed the correctionlib-deprecation-ok branch from 9c56f0f to b2bb985 Compare October 19, 2025 20:20
@sarahec sarahec changed the title python3Packages.correctionlib: silence deprecation error with clang python3Packages.correctionlib: reduce churn on compiler updates Oct 19, 2025
@sarahec
Copy link
Contributor Author

sarahec commented Oct 19, 2025

We should drop Werror to reduce churn on compiler updates https://github.com/search?q=repo%3Acms-nanoAOD%2Fcorrectionlib%20werror&type=code

Also the wall wextra and wpedenatic should be removed as they probably spam the log with warnings.

@SuperSandro2000 done!

@iedame
Copy link
Contributor

iedame commented Oct 21, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451855
Commit: b2bb98561a98806f391c427bf46531b14c45a52f (subsequent changes)
Merge: 03c4630fa05dca0136482c2f4659507765a90527

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18693686515

x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
✅ 4 packages built:
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist
  • python313Packages.correctionlib
  • python313Packages.correctionlib.dist

aarch64-linux

❌ 4 packages failed to build:
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
✅ 4 packages built:
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist
  • python313Packages.correctionlib
  • python313Packages.correctionlib.dist

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
✅ 4 packages built:
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist
  • python313Packages.correctionlib
  • python313Packages.correctionlib.dist

aarch64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.coffea
  • python312Packages.coffea.dist
  • python313Packages.coffea
  • python313Packages.coffea.dist
✅ 4 packages built:
  • python312Packages.correctionlib
  • python312Packages.correctionlib.dist
  • python313Packages.correctionlib
  • python313Packages.correctionlib.dist

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 21, 2025
@veprbl veprbl added this pull request to the merge queue Oct 22, 2025
Merged via the queue into NixOS:master with commit abdee29 Oct 22, 2025
30 of 33 checks passed
@sarahec sarahec deleted the correctionlib-deprecation-ok branch October 22, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

+1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarahec @SuperSandro2000 @iedame @veprbl