Skip to content

ruby_{3_1,3_2}: drop#451385

Merged
LeSuisse merged 10 commits intoNixOS:masterfrom
emilazy:push-uvzmuzknukyl
Oct 12, 2025
Merged

ruby_{3_1,3_2}: drop#451385
LeSuisse merged 10 commits intoNixOS:masterfrom
emilazy:push-uvzmuzknukyl

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Oct 12, 2025 •
edited
Loading

3.1 is already EOL, 3.2 will go EOL during 25.11.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux (sonic-pi)
    • x86_64-darwin
    • aarch64-darwin (tree-from-tags)
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy mentioned this pull request Oct 12, 2025
Merged
13 tasks
@emilazy emilazy marked this pull request as draft October 12, 2025 16:13
@emilazy
Copy link
Member Author

emilazy commented Oct 12, 2025

Spoke too soon about the sonic-pi build, it got past the Ruby stuff that was failing but ran into other issues. Will fix.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation labels Oct 12, 2025
@emilazy
Copy link
Member Author

emilazy commented Oct 12, 2025

No idea why autoPatchelfHook stopped being able to find ncurses with the Ruby change, but fixed. This should be good to go now.

@emilazy emilazy marked this pull request as ready for review October 12, 2025 16:51
LeSuisse
LeSuisse approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks for the tags on macvim.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451385
Commit: 2f42412f783baad067a4f51b160f4b7b190c5057

x86_64-linux

⏩ 1 package marked as broken and skipped:
  • tests.pkg-config.defaultPkgConfigPackages.tests-combined
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 packages built:
  • nixpkgs-manual
  • sonic-pi
  • tree-from-tags
  • unit

@LeSuisse LeSuisse added this pull request to the merge queue Oct 12, 2025
Merged via the queue into NixOS:master with commit 16849c8 Oct 12, 2025
30 of 33 checks passed
@github-project-automation github-project-automation bot moved this from To do to Done in Picking up garbage Oct 12, 2025
@nim65s nim65s mentioned this pull request Oct 13, 2025
Merged
13 tasks
lilyball
lilyball reviewed Oct 23, 2025
View reviewed changes
pkgs/applications/editors/vim/macvim.nix
Comment on lines +220 to +244
knownVulnerabilities = [
"CVE-2023-46246"
"CVE-2023-48231"
"CVE-2023-48232"
"CVE-2023-48233"
"CVE-2023-48234"
"CVE-2023-48235"
"CVE-2023-48236"
"CVE-2023-48237"
"CVE-2023-48706"
"CVE-2023-5344"
"CVE-2023-5441"
"CVE-2023-5535"
"CVE-2024-22667"
"CVE-2024-41957"
"CVE-2024-41965"
"CVE-2024-43374"
"CVE-2024-47814"
"CVE-2025-1215"
"CVE-2025-22134"
"CVE-2025-24014"
"CVE-2025-26603"
"CVE-2025-29768"
"CVE-2025-53905"
"CVE-2025-53906"
Copy link
Member

@lilyball lilyball Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this list come from? Everything up to CVE-2024-22667 is about Vim 9.0.x versions, and MacVim r179 is Vim 9.1. The ones starting with CVE-2024-41957 are presumably valid, since that one is about Vim 9.1.x.

Copy link
Member Author

@emilazy emilazy Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s from https://nvd.nist.gov/vuln/search#/nvd/home?cpeFilterMode=cpe&cpeName=cpe:2.3:a:vim:vim:9.0.1897:*:*:*:*:*:*:*&resultType=records; I think I mixed up the base Vim version with the previous one. The correct list is presumably https://nvd.nist.gov/vuln/search#/nvd/home?cpeFilterMode=cpe&cpeName=cpe:2.3:a:vim:vim:9.1.0000:*:*:*:*:*:*:*&resultType=records, which matches CVE-2024-41957 as the starting point. Sorry about that. Fix is #454720.

Copy link
Member

@LeSuisse LeSuisse Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPE are always a pleasure to work with 😩

@emilazy emilazy deleted the push-uvzmuzknukyl branch October 23, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@Izorkin Izorkin Awaiting requested review from Izorkin

@c0deaddict c0deaddict Awaiting requested review from c0deaddict

@Phlogistique Phlogistique Awaiting requested review from Phlogistique

@kamilchm kamilchm Awaiting requested review from kamilchm

@Sohalt Sohalt Awaiting requested review from Sohalt

@manveru manveru Awaiting requested review from manveru

+1 more reviewer

@lilyball lilyball lilyball left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Picking up garbage
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilazy @lilyball @LeSuisse