ceph: fix cmake 4 failure on arrow-cpp#451124
Closed
limwa wants to merge 1 commit intoNixOS:stagingfrom
Closed
Conversation
a8a0006 to
d1c9876
Compare
Member
|
See also #451118 from a few minutes ago :) CMake 4 is in |
Contributor
Author
|
I targeted staging because ceph already does not build on master because of python-tkinter and the fix for that is in staging.
That's unlucky hahaha, I was just waiting for the package to finish building :') |
Contributor
Author
|
I'll close this PR, thank you! |
Member
Ah, forgot about that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
staging-next, ceph does not build because its vendored arrow-cpp does not support CMake 4.Upstream has merged a patch (apache/arrow#45997) that sets the minimum policy version for its third-party dependencies.
This pull request adds that patch to ceph's arrow-cpp build.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.