Skip to content

ceph: fix cmake 4 failure on arrow-cpp#451124

Closed
limwa wants to merge 1 commit intoNixOS:stagingfrom
limwa:ceph-arrow-cpp-cmake-4-compat
Closed

ceph: fix cmake 4 failure on arrow-cpp#451124
limwa wants to merge 1 commit intoNixOS:stagingfrom
limwa:ceph-arrow-cpp-cmake-4-compat

Conversation

@limwa
Copy link
Contributor

@limwa limwa commented Oct 11, 2025

In staging-next, ceph does not build because its vendored arrow-cpp does not support CMake 4.

Upstream has merged a patch (apache/arrow#45997) that sets the minimum policy version for its third-party dependencies.

This pull request adds that patch to ceph's arrow-cpp build.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@limwa limwa force-pushed the ceph-arrow-cpp-cmake-4-compat branch from a8a0006 to d1c9876 Compare October 11, 2025 21:03
@emilazy
Copy link
Member

emilazy commented Oct 11, 2025

See also #451118 from a few minutes ago :)

CMake 4 is in master now, so staging is probably the wrong target branch here?

@limwa
Copy link
Contributor Author

limwa commented Oct 11, 2025

I targeted staging because ceph already does not build on master because of python-tkinter and the fix for that is in staging.

See also #451118 from a few minutes ago :)

That's unlucky hahaha, I was just waiting for the package to finish building :')

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 11, 2025
@limwa
Copy link
Contributor Author

limwa commented Oct 11, 2025

I'll close this PR, thank you!

@limwa limwa closed this Oct 11, 2025
@emilazy
Copy link
Member

emilazy commented Oct 11, 2025

I targeted staging because ceph already does not build on master because of python-tkinter and the fix for that is in staging.

Ah, forgot about that :)

@limwa limwa deleted the ceph-arrow-cpp-cmake-4-compat branch November 25, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants