Skip to content

lib.systems: Simplify ABI on POWER for rust.rustcTarget#451087

Merged
alyssais merged 2 commits intoNixOS:masterfrom
OPNA2608:fix/power-rust-elf-abi
Oct 25, 2025
Merged

lib.systems: Simplify ABI on POWER for rust.rustcTarget#451087
alyssais merged 2 commits intoNixOS:masterfrom
OPNA2608:fix/power-rust-elf-abi

Conversation

@OPNA2608
Copy link
Contributor

Move the fix from just lib.systems.examples.ppc64-elfv1 into generic code, so it gets automatically applied for both ABI targets and any manually specified *System settings.

(If someone from the Rust team has any advice for how I could actually tell Rust what ABI it should use, or whether they even have such an option, please let me know! From browsing upstream issues & PRs, it's possible to query the ABI in use in Rust code, but I don't really see anything about telling the compiler which one it should actually use… Not urgent though, glibc ELFv2 is really low on my list of priorities.)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Rust does not know how to parse "gnuabielfv{1,2}", so simplify those down to just "gnu".
This obsoletes the manual rustcTarget fix in the ppc64-elfv1 example.
@OPNA2608 OPNA2608 force-pushed the fix/power-rust-elf-abi branch from d0c33cf to 8448c28 Compare October 11, 2025 18:57
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: lib The Nixpkgs function library labels Oct 11, 2025
@OPNA2608 OPNA2608 added the 6.topic: exotic Exotic hardware or software platform label Oct 11, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 22, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 25, 2025
@alyssais alyssais added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 9711c5a Oct 25, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: exotic Exotic hardware or software platform 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants