lib.systems: Simplify ABI on POWER for rust.rustcTarget#451087
Merged
alyssais merged 2 commits intoNixOS:masterfrom Oct 25, 2025
Merged
lib.systems: Simplify ABI on POWER for rust.rustcTarget#451087alyssais merged 2 commits intoNixOS:masterfrom
alyssais merged 2 commits intoNixOS:masterfrom
Conversation
Rust does not know how to parse "gnuabielfv{1,2}", so simplify those down to just "gnu".
This obsoletes the manual rustcTarget fix in the ppc64-elfv1 example.
ABI is now simplified automatically.
d0c33cf to
8448c28
Compare
alyssais
approved these changes
Oct 22, 2025
Mindavi
approved these changes
Oct 25, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the fix from just
lib.systems.examples.ppc64-elfv1into generic code, so it gets automatically applied for both ABI targets and any manually specified*Systemsettings.(If someone from the Rust team has any advice for how I could actually tell Rust what ABI it should use, or whether they even have such an option, please let me know! From browsing upstream issues & PRs, it's possible to query the ABI in use in Rust code, but I don't really see anything about telling the compiler which one it should actually use… Not urgent though, glibc ELFv2 is really low on my list of priorities.)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.