Skip to content

Revert "python311Packages.tkinter: mark broken"#451036

Merged
emilazy merged 2 commits intoNixOS:staging-nextfrom
dotlambda:python3Packages.tkinter
Oct 11, 2025
Merged

Revert "python311Packages.tkinter: mark broken"#451036
emilazy merged 2 commits intoNixOS:staging-nextfrom
dotlambda:python3Packages.tkinter

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 11, 2025

This reverts #450886 because python311Packages.tkinter was fixed in #442184.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda mentioned this pull request Oct 11, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 11, 2025
emilazy
emilazy approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed the master vs. staging-next difference here. Good catch, thank you!

@emilazy emilazy merged commit 2cf95d0 into NixOS:staging-next Oct 11, 2025
31 of 35 checks passed
@dotlambda dotlambda deleted the python3Packages.tkinter branch October 11, 2025 16:18
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 12, 2025

Whoops, sorry about that!

@emilazy
Copy link
Member

emilazy commented Oct 12, 2025

No worries – it’s at least accurate on master right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @SigmaSquadron @emilazy