Skip to content

openssh: make the NixOS tests for openssh test the actual derivation being built#450716

Merged
LeSuisse merged 1 commit intoNixOS:masterfrom
philiptaron:openssh-nixos-test
Oct 10, 2025
Merged

openssh: make the NixOS tests for openssh test the actual derivation being built#450716
LeSuisse merged 1 commit intoNixOS:masterfrom
philiptaron:openssh-nixos-test

Conversation

@philiptaron
Copy link
Contributor

@philiptaron philiptaron commented Oct 10, 2025

I noticed that running the NixOS tests for the OpenSSH variants wasn't actually testing them.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 10, 2025
@philiptaron philiptaron mentioned this pull request Oct 10, 2025
13 tasks
@philiptaron
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450716 --package openssh_hpnWithKerberos.tests --package openssh_hpn.tests --package openssh_gssapi.tests --package openssh.tests
Commit: 3ba43bda1d574f441500c2b4d89d00c5e61d5e86


x86_64-linux

❌ 3 packages failed to build:
  • openssh_gssapi.tests.openssh
  • openssh_hpn.tests.openssh
  • openssh_hpnWithKerberos.tests.openssh
✅ 10 packages built:
  • openssh.tests.borgbackup-integration
  • openssh.tests.initrd-network-openssh
  • openssh.tests.nixosTest
  • openssh.tests.openssh
  • openssh_gssapi.tests.borgbackup-integration
  • openssh_gssapi.tests.nixosTest
  • openssh_hpn.tests.borgbackup-integration
  • openssh_hpn.tests.nixosTest
  • openssh_hpnWithKerberos.tests.borgbackup-integration
  • openssh_hpnWithKerberos.tests.nixosTest

Error logs: `x86_64-linux`
openssh_gssapi.tests.openssh
sftp timeout
Connection closed
sftp irrelevant timeout
ok channel timeout
run test connection-timeout.sh ...
no timeout
timeout
session inhibits timeout
timeout after session
timeout with listeners
ok unused connection timeout
run test match-subsystem.sh ...
ok sshd_config match subsystem
run test agent-pkcs11-restrict.sh ...
unrestricted keys
Could not add card "/nix/store/ac0m1sasrpgv44lnzqnjizj4ks24x8md-softhsm-2.6.1/lib/softhsm/libsofthsm2.so": agent refused operation
FATAL: failed to add keys
make[1]: *** [Makefile:239: t-exec] Error 1
make[1]: Leaving directory '/build/openssh-10.1p1/regress'
make: *** [Makefile:787: t-exec] Error 2

@philiptaron
Copy link
Contributor Author

I think the test failures are pre-existing.

Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with that!

@LeSuisse LeSuisse added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit a03569f Oct 10, 2025
31 of 35 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2025
@philiptaron philiptaron deleted the openssh-nixos-test branch October 10, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants