openssh: make the NixOS tests for openssh test the actual derivation being built#450716
Merged
LeSuisse merged 1 commit intoNixOS:masterfrom Oct 10, 2025
Merged
openssh: make the NixOS tests for openssh test the actual derivation being built#450716LeSuisse merged 1 commit intoNixOS:masterfrom
LeSuisse merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
Contributor
Author
|
Contributor
Author
|
I think the test failures are pre-existing. |
LeSuisse
approved these changes
Oct 10, 2025
Member
LeSuisse
left a comment
There was a problem hiding this comment.
Thanks for dealing with that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that running the NixOS tests for the OpenSSH variants wasn't actually testing them.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.