Skip to content

catalyst: fix build on x86_64-darwin#450241

Merged
NickCao merged 1 commit intoNixOS:masterfrom
qbisi:catalyst
Oct 13, 2025
Merged

catalyst: fix build on x86_64-darwin#450241
NickCao merged 1 commit intoNixOS:masterfrom
qbisi:catalyst

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 9, 2025

darwin stdenv swtich to use system libc++ from sdk, hence the abi test failed on x86_64-darwin.
fix build by disabling abi test on x86_64-darwin.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 9, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Oct 9, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450241 -p catalyst
Commit: 4d0a26cf9907f187db545cb2798cab9939dd8435 (subsequent changes)
Merge: 4e25d32b9eebd7479c9e37ae38b25ce3d530375a

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18374024456


x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • catalyst

Error logs: `x86_64-darwin`
catalyst
      Start 41: test-install-replay_missing_initialize_data-prepare
40/46 Test #41: test-install-replay_missing_initialize_data-prepare ...   Passed    0.24 sec
      Start 42: test-install-replay_missing_initialize_data
41/46 Test #38: test-install-replay_no_data_dump_dir ..................   Passed   49.77 sec
      Start 44: test-build-replay_missing_execute_invc
42/46 Test #40: test-build-replay_missing_initialize_data .............   Passed   49.65 sec
      Start 45: test-install-replay_missing_execute_invc-prepare
43/46 Test #45: test-install-replay_missing_execute_invc-prepare ......   Passed    0.28 sec
      Start 46: test-install-replay_missing_execute_invc
44/46 Test #42: test-install-replay_missing_initialize_data ...........   Passed   52.71 sec
45/46 Test #44: test-build-replay_missing_execute_invc ................   Passed   50.84 sec
46/46 Test #46: test-install-replay_missing_execute_invc ..............   Passed   49.94 sec

98% tests passed, 1 tests failed out of 46

Total Test time (real) = 284.89 sec

The following tests FAILED:
17 - catalyst-abi-nm (Failed)
Errors while running CTest

@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450241 -p catalyst
Commit: af63cefc4600e88b8b1e4bd4b523740720f9fc66 (subsequent changes)
Merge: f593deb6586ac1895df1140921c389a033bb54c9

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18380208859


x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • catalyst

Error logs: `x86_64-darwin`
catalyst
      Start 41: test-install-replay_missing_initialize_data-prepare
40/46 Test #41: test-install-replay_missing_initialize_data-prepare ...   Passed    0.25 sec
      Start 42: test-install-replay_missing_initialize_data
41/46 Test #38: test-install-replay_no_data_dump_dir ..................   Passed   41.33 sec
      Start 44: test-build-replay_missing_execute_invc
42/46 Test #40: test-build-replay_missing_initialize_data .............   Passed   41.80 sec
      Start 45: test-install-replay_missing_execute_invc-prepare
43/46 Test #45: test-install-replay_missing_execute_invc-prepare ......   Passed    0.46 sec
      Start 46: test-install-replay_missing_execute_invc
44/46 Test #44: test-build-replay_missing_execute_invc ................   Passed   42.66 sec
45/46 Test #42: test-install-replay_missing_initialize_data ...........   Passed   44.17 sec
46/46 Test #46: test-install-replay_missing_execute_invc ..............   Passed   42.53 sec

98% tests passed, 1 tests failed out of 46

Total Test time (real) = 313.56 sec

The following tests FAILED:
17 - catalyst-abi-nm (Failed)
Errors while running CTest

@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

@NixOS/darwin-core is there anything changed to darwin stdenv in #444862

@reckenrode
Copy link
Contributor

Clang was updated to Clang 21. The SDK stuff is coming in the next cycle.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

I can disable the failing test, just curious about the root cause of the abi test failing. (who bring in those unexpected symbols)
Note that catalyst is not broken on aarch64-darwin.

@reckenrode
Copy link
Contributor

That might also have been the staging cycle when Darwin switched to the system libc++.

@reckenrode
Copy link
Contributor

I can disable the failing test, just curious about the root cause of the abi test failing. (who bring in those unexpected symbols) Note that catalyst is not broken on aarch64-darwin.

Probably the only way to know is to build locally with --keep-failed to check the log for which symbols it’s unexpectedly finding.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

According to build log, these symbols are unwanted.

2025-10-09T15:48:11.3135860Z catalyst> 29/46 Test #17: catalyst-abi-nm .......................................***Failed   17.24 sec
2025-10-09T15:48:11.3239040Z catalyst> CMake Error at /nix/build/nix-46490-916922739/source/tests/abi_tests/nm.cmake:88 (message):
2025-10-09T15:48:11.3339240Z catalyst>   Unexpected symbols found:
2025-10-09T15:48:11.3441360Z catalyst>   __ZTINSt3__113basic_filebufIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.3543510Z catalyst>   __ZTINSt3__114basic_ifstreamIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.3645190Z catalyst>   __ZTINSt3__114basic_ofstreamIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.3745220Z catalyst>   __ZTINSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.3847470Z catalyst>   __ZTINSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.3949800Z catalyst>   __ZTINSt3__119basic_istringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.3952120Z catalyst>   __ZTINSt3__119basic_ostringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.3952760Z catalyst>   __ZTSNSt3__113basic_filebufIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.3954180Z catalyst>   __ZTSNSt3__114basic_ifstreamIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.4055780Z catalyst>   __ZTSNSt3__114basic_ofstreamIcNS_11char_traitsIcEEEE,
2025-10-09T15:48:11.4162840Z catalyst>   __ZTSNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.4265640Z catalyst>   __ZTSNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.4368470Z catalyst>   __ZTSNSt3__119basic_istringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE,
2025-10-09T15:48:11.4470110Z catalyst>   __ZTSNSt3__119basic_ostringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE

I guess these symbols come from libc++ from the latest SDK.

@qbisi qbisi marked this pull request as ready for review October 9, 2025 17:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Oct 9, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450241 -p catalyst
Commit: eebf227b5fe741c738b2af7f448e43ddc8eb0dfe (subsequent changes)
Merge: ce45b60be65e43fe75b54d46cd38653632ec469d

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18384540230


x86_64-darwin (sandbox = true)

✅ 1 package built:
  • catalyst

@NickCao NickCao added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 4e49f13 Oct 13, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants