Skip to content

rquickshare-legacy: drop#450113

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
PerchunPak:rquickshare-webkit41
Oct 9, 2025
Merged

rquickshare-legacy: drop#450113
Sigmanificient merged 1 commit intoNixOS:masterfrom
PerchunPak:rquickshare-webkit41

Conversation

@PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Oct 8, 2025

Drops the legacy version, as it depends on an insecure libsoup2 package (see #450065). The main version should be fine.

rquickshare-legacy is already unavailable on master, as libsoup2 is marked as an insecure package and fails eval.

The derivation has changed because of the order in buildInputs:
image

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450113
Commit: de8a66f15df43a2b3de18613ced34ee4a0f737ee (subsequent changes)
Merge: 95948225023e04c4fd78c673090a25f607c6cf50

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18372279141


x86_64-linux

✅ 1 package built:
  • rquickshare

aarch64-linux

✅ 1 package built:
  • rquickshare

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 9, 2025
@PerchunPak PerchunPak force-pushed the rquickshare-webkit41 branch from de8a66f to b08732c Compare October 9, 2025 16:33
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sandro for catching this typo :)

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit dfc2e82 Oct 9, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants