Skip to content

openblas: 0.3.30 -> 0.3.31#450106

Merged
doronbehar merged 2 commits intoNixOS:stagingfrom
pcc:openblas
Mar 3, 2026
Merged

openblas: 0.3.30 -> 0.3.31#450106
doronbehar merged 2 commits intoNixOS:stagingfrom
pcc:openblas

Conversation

@pcc
Copy link
Contributor

@pcc pcc commented Oct 8, 2025

Submitted pull request upstream:
OpenMathLib/OpenBLAS#5495

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from ttuegel October 8, 2025 23:12
@pcc pcc mentioned this pull request Oct 9, 2025
Merged
uninsane
uninsane reviewed Oct 20, 2025
View reviewed changes
pkgs/development/libraries/science/math/openblas/default.nix Outdated
# Remove this once https://github.com/OpenMathLib/OpenBLAS/issues/5414 is
# resolved.
./disable-sme-sgemm-kernel.patch
./0001-Fix-cross-compilation-for-x86-targets-from-non-x86.patch
Copy link
Contributor

@uninsane uninsane Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you include a link to the OpenMathLib/OpenBLAS#5495 to make it easier to track the status of this patch (e.g. makes it easy to tell, next time the package is updated, if it's OK to remove this patch).

since it's been merged upstream, you could even fetchpatch it -- if you prefer.

Copy link
Member

@ttuegel ttuegel Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pretty strongly prefer to fetchpatch this since it was accepted upstream.

Copy link
Contributor

@doronbehar doronbehar Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the author of the PR doesn't respond, and this patch and other already included patches are part of the 0.3.31 upstream release, I pushed here these changes.

uninsane
uninsane approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built native & cross, outputs LGTM.

the feedback left above is just a suggestion, not a blocker

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 20, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 16, 2025
@doronbehar doronbehar changed the base branch from master to staging January 18, 2026 23:57
@nixpkgs-ci nixpkgs-ci bot closed this Jan 18, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Jan 18, 2026
github-actions[bot]

This comment was marked as resolved.

Sign in to view

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 19, 2026
@github-actions github-actions bot dismissed their stale review January 19, 2026 00:01

All good now, thank you!

@doronbehar doronbehar requested a review from uninsane January 19, 2026 00:01
@doronbehar doronbehar changed the title openblas: apply cross compilation fix openblas: 0.3.30 -> 0.3.31 Jan 20, 2026
@nixpkgs-ci nixpkgs-ci bot added the 8.has: package (update) This PR updates a package to a newer version label Jan 26, 2026
@doronbehar doronbehar added this pull request to the merge queue Mar 3, 2026
@doronbehar
Copy link
Contributor

doronbehar commented Mar 3, 2026

Merging due to no objections.

Merged via the queue into NixOS:staging with commit 5b2464f Mar 3, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar doronbehar left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@ttuegel ttuegel Awaiting requested review from ttuegel

@uninsane uninsane Awaiting requested review from uninsane

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pcc @doronbehar @ttuegel @uninsane