Skip to content

pytrainer: Upgrade to webkitgtk_4_1#450075

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:pytrainer-wk41
Oct 9, 2025
Merged

pytrainer: Upgrade to webkitgtk_4_1#450075
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:pytrainer-wk41

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 8, 2025

See #450065

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
@nix-owners nix-owners bot requested review from dotlambda and rycee October 8, 2025 22:06
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450075
Commit: bcb8143947a5f00e1eb4f1ebca6d9d29b3535421 (subsequent changes)
Merge: 799d3f3f8df69226806ba1376e6d19f7f9682b16

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18372280119


x86_64-linux

✅ 2 packages built:
  • pytrainer
  • pytrainer.dist

aarch64-linux

✅ 2 packages built:
  • pytrainer
  • pytrainer.dist

@jtojnar
Copy link
Member Author

jtojnar commented Oct 9, 2025

Looks like it does not start anyway:

Traceback (most recent call last):
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/bin/..pytrainer-wrapped-wrapped", line 103, in <module>
    main()
    ~~~~^^
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/bin/..pytrainer-wrapped-wrapped", line 99, in main
    pytrainer = pyTrainer()
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/main.py", line 79, in __init__
    initialize_data(self.ddbb, self.environment.conf_dir)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/upgrade/data.py", line 30, in initialize_data
    InstalledData(migratable_db, ddbb, LegacyVersionProvider(conf_dir), UpgradeContext(conf_dir, db_url)).update_to_current()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/upgrade/data.py", line 62, in update_to_current
    data_state = self.get_state()
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/upgrade/data.py", line 83, in get_state
    if self.is_fresh():
       ~~~~~~~~~~~~~^^
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/upgrade/data.py", line 92, in is_fresh
    return self._migratable_db.is_empty()
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/nix/store/xbl4nd4dld7k2iqapygm7czh98chl731-pytrainer-2.2.1/lib/python3.13/site-packages/pytrainer/upgrade/migratedb.py", line 55, in is_empty
    metadata.reflect()
    ~~~~~~~~~~~~~~~~^^
TypeError: MetaData.reflect() missing 1 required positional argument: 'bind'

@jtojnar jtojnar added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit f00b180 Oct 9, 2025
30 of 34 checks passed
@jtojnar jtojnar deleted the pytrainer-wk41 branch October 9, 2025 12:21
@dotlambda
Copy link
Member

Looks like it does not start anyway

marking the package broken in #450356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants