Skip to content

ente-auth: fix build error identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated#449997

Merged
niklaskorz merged 1 commit intoNixOS:masterfrom
iedame:fix/ente-auth
Oct 8, 2025
Merged

ente-auth: fix build error identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated#449997
niklaskorz merged 1 commit intoNixOS:masterfrom
iedame:fix/ente-auth

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 8, 2025

ente-auth is failing on unstable and unstable-small.
This build error was likely introduced by #444862:

Error log:
[        ] In file included from /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/flutter_secure_storage_linux_plugin.cc:2:
[        ] In file included from /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/include/Secret.hpp:2:
[        ] /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/include/json.hpp:24392:35: error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24392 | inline nlohmann::json operator "" _json(const char* s, std::size_t n)
[        ]        |                       ~~~~~~~~~~~~^~~~~
[        ]        |                       operator""_json
[        ] /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/include/json.hpp:24400:49: error: identifier '_json_pointer' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24400 | inline nlohmann::json::json_pointer operator "" _json_pointer(const char* s, std::size_t n)
[        ]        |                                     ~~~~~~~~~~~~^~~~~~~~~~~~~
[        ]        |                                     operator""_json_pointer
[        ] /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/include/json.hpp:24464:58: error: identifier '_json' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24464 |     using nlohmann::literals::json_literals::operator "" _json; // NOLINT(misc-unused-using-decls,google-global-names-in-headers)
[        ]        |                                              ~~~~~~~~~~~~^~~~~
[        ]        |                                              operator""_json
[        ] /build/source/mobile/apps/auth/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/include/json.hpp:24465:58: error: identifier '_json_pointer' preceded by whitespace in a literal operator declaration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24465 |     using nlohmann::literals::json_literals::operator "" _json_pointer; //NOLINT(misc-unused-using-decls,google-global-names-in-headers)
[        ]        |                                              ~~~~~~~~~~~~^~~~~~~~~~~~~
[        ]        |                                              operator""_json_pointer
[        ] 4 errors generated.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

…n a literal operator declaration is deprecated
@iedame iedame changed the title ente-auth: fix build error: identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated ente-auth: fix build error identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated Oct 8, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 8, 2025

@LudovicoPiero Please test this quick fix, it is building fine now for me on unstable x86_64-linux.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449997
Commit: 784d3012282b356a8da9f99d0056bc291090c139 (subsequent changes)
Merge: 8df2231b58626cf000e518013dcc980f1e089c8a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18352457151


x86_64-linux

✅ 3 packages built:
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache

aarch64-linux

✅ 3 packages built:
  • ente-auth
  • ente-auth.debug
  • ente-auth.pubcache

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Member

@LudovicoPiero LudovicoPiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it — builds fine now. Thanks for the quick PR!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the binary, thanks for the fix!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 8, 2025
@niklaskorz niklaskorz enabled auto-merge October 8, 2025 18:33
@niklaskorz niklaskorz added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit b234919 Oct 8, 2025
37 of 41 checks passed
@iedame iedame deleted the fix/ente-auth branch October 8, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants