Conversation
|
Apologies, I've forgotten to run a formatter. Sorry, this is my first PR here. Let me know and I'll send a fresh PR. |
|
OP, note that we have local title conventions (apply for both commits and PRs). The correct format should be Also, new packages are supposed to be added in two commits:
See more in the contributing docs on commit naming and commit hygiene. May |
|
and a non-blocking tip for the future (and your own convenience): never use your fork's
This PR can still be accepted as is, DO NOT CLOSE IT |
acid-bong
left a comment
There was a problem hiding this comment.
i'm not sure i'll have enough attention span currently to review the rest of the code, but here it is
pkgs/by-name/vi/vicinae/package.nix
Outdated
There was a problem hiding this comment.
now onto the code itself:
- simply adding a package recipe isn't enough, isn't not used anywhere in Nixpkgs. Recipes in dirs other than
by-namemust be initiated inpkgs/top-level/all-packages.nix - BUT! if you actually read the contributing docs, you'd see that
by-nameis preferred currently for standalone programs: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy. It populatespkgsautomatically and doesn't need extra initiation, your job is to justmkdir -p pkgs/by-name/vi/vicinaeandgit mv THIS_FILE pkgs/by-name/vi/vicinae/package.nix
|
Please see https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy to properly name your PR and commits |
|
once again, follow the commit hygiene as suggested in #449957 (comment) |
|
I'll create a new PR. Sorry for the confusion. |
Things done
packaged vicinae
Built on platform:
Tested, as applicable:
passthru.tests.Ran
nixpkgs-reviewon this PR. See nixpkgs-review usage.Tested basic functionality of all binary files, usually in
./result/bin/.Nixpkgs Release Notes
NixOS Release Notes
Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.
Add a 👍 reaction to pull requests you find important.