Skip to content

vicinae: Added vicinae#449957

Closed
zstg wants to merge 0 commit intoNixOS:masterfrom
zstg:master
Closed

vicinae: Added vicinae#449957
zstg wants to merge 0 commit intoNixOS:masterfrom
zstg:master

Conversation

@zstg
Copy link
Copy Markdown
Member

@zstg zstg commented Oct 8, 2025

Things done

  • packaged vicinae

  • Built on platform:

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:

  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.

  • Tested basic functionality of all binary files, usually in ./result/bin/.

  • Nixpkgs Release Notes

    • Package update: when the change is major or breaking.
  • NixOS Release Notes

    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.


Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Oct 8, 2025
@zstg
Copy link
Copy Markdown
Member Author

zstg commented Oct 8, 2025

Apologies, I've forgotten to run a formatter. Sorry, this is my first PR here.

Let me know and I'll send a fresh PR.

@acid-bong
Copy link
Copy Markdown
Contributor

OP, note that we have local title conventions (apply for both commits and PRs). The correct format should be PROGRAM: CHANGES, if you're editing a package, or nixos/PROGRAM: CHANGES, if it's a NixOS module.

Also, new packages are supposed to be added in two commits:

  1. new maintainer entry (optional, only if it's your first package/module/test),
  2. new package itself.

See more in the contributing docs on commit naming and commit hygiene.

May git commit --amend, git rebase -i and git push --force-with-lease be with you 🖖 DO NOT CLOSE THE PR

@zstg zstg changed the title Added vicinae nixos/vicinae: Added vicinae Oct 8, 2025
@zstg zstg changed the title nixos/vicinae: Added vicinae vicinae: Added vicinae Oct 8, 2025
@acid-bong
Copy link
Copy Markdown
Contributor

and a non-blocking tip for the future (and your own convenience): never use your fork's master to make PRs from, always branch out

  • your fork's master is only for being synced with the upstream master
  • with a separate branch, you can rebase it onto a fresher master commit, if necessary

This PR can still be accepted as is, DO NOT CLOSE IT

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
Copy link
Copy Markdown
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure i'll have enough attention span currently to review the rest of the code, but here it is

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now onto the code itself:

  1. simply adding a package recipe isn't enough, isn't not used anywhere in Nixpkgs. Recipes in dirs other than by-name must be initiated in pkgs/top-level/all-packages.nix
  2. BUT! if you actually read the contributing docs, you'd see that by-name is preferred currently for standalone programs: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#category-hierarchy. It populates pkgs automatically and doesn't need extra initiation, your job is to just mkdir -p pkgs/by-name/vi/vicinae and git mv THIS_FILE pkgs/by-name/vi/vicinae/package.nix

@acid-bong
Copy link
Copy Markdown
Contributor

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
@zstg zstg requested a review from acid-bong October 8, 2025 16:26
@acid-bong
Copy link
Copy Markdown
Contributor

once again, follow the commit hygiene as suggested in #449957 (comment)

@zstg zstg closed this Oct 9, 2025
@zstg
Copy link
Copy Markdown
Member Author

zstg commented Oct 9, 2025

I'll create a new PR. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants