Skip to content

server-box: fix build error: identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated#449770

Merged
symphorien merged 1 commit intoNixOS:masterfrom
UlyssesZh:server-box-fix
Oct 11, 2025
Merged

server-box: fix build error: identifier 'xxx' preceded by whitespace in a literal operator declaration is deprecated#449770
symphorien merged 1 commit intoNixOS:masterfrom
UlyssesZh:server-box-fix

Conversation

@UlyssesZh
Copy link
Member

The build error was introduced by #444862:

Error log
[        ] In file included from /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_sto
rage_linux/linux/flutter_secure_storage_linux_plugin.cc:2:
[        ] In file included from /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_sto
rage_linux/linux/include/Secret.hpp:2:
[        ] /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/inclu
de/json.hpp:24392:35: error: identifier '_json' preceded by whitespace in a literal operator declaration i
s deprecated [-Werror,-Wdeprecated-literal-operator]
[   +1 ms]  24392 | inline nlohmann::json operator "" _json(const char* s, std::size_t n)
[        ]        |                       ~~~~~~~~~~~~^~~~~
[        ]        |                       operator""_json
[        ] /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/inclu
de/json.hpp:24400:49: error: identifier '_json_pointer' preceded by whitespace in a literal operator decla
ration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24400 | inline nlohmann::json::json_pointer operator "" _json_pointer(const char* s, std::size
_t n)
[        ]        |                                     ~~~~~~~~~~~~^~~~~~~~~~~~~
[        ]        |                                     operator""_json_pointer
[        ] /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/inclu
de/json.hpp:24464:58: error: identifier '_json' preceded by whitespace in a literal operator declaration i
s deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24464 |     using nlohmann::literals::json_literals::operator "" _json; // NOLINT(misc-unused-
using-decls,google-global-names-in-headers)
[        ]        |                                              ~~~~~~~~~~~~^~~~~
[        ]        |                                              operator""_json
[        ] /build/source/linux/flutter/ephemeral/.plugin_symlinks/flutter_secure_storage_linux/linux/inclu
de/json.hpp:24465:58: error: identifier '_json_pointer' preceded by whitespace in a literal operator decla
ration is deprecated [-Werror,-Wdeprecated-literal-operator]
[        ]  24465 |     using nlohmann::literals::json_literals::operator "" _json_pointer; //NOLINT(misc-
unused-using-decls,google-global-names-in-headers)
[        ]        |                                              ~~~~~~~~~~~~^~~~~~~~~~~~~
[        ]        |                                              operator""_json_pointer
[        ] 4 errors generated.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

…in a literal operator declaration is deprecated
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449770
Commit: 3bf045bb2c066b8b3c3c447c6b8faf849001ecf9 (subsequent changes)
Merge: 1ae5272d51f7a2eefe26c91349a61e29ce3cecb3

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18341473977


x86_64-linux

✅ 3 packages built:
  • server-box
  • server-box.debug
  • server-box.pubcache

aarch64-linux

✅ 3 packages built:
  • server-box
  • server-box.debug
  • server-box.pubcache

@iedame
Copy link
Contributor

iedame commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449770
Commit: 3bf045bb2c066b8b3c3c447c6b8faf849001ecf9 (subsequent changes)
Merge: b033621998897d90b1d97c2e2fbb77689957c965

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18352790992


x86_64-linux

✅ 3 packages built:
  • server-box
  • server-box.debug
  • server-box.pubcache

aarch64-linux

✅ 3 packages built:
  • server-box
  • server-box.debug
  • server-box.pubcache

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@symphorien symphorien added this pull request to the merge queue Oct 11, 2025
Merged via the queue into NixOS:master with commit 20844f8 Oct 11, 2025
34 of 36 checks passed
@SuperSandro2000
Copy link
Member

Please patch out Werror here https://github.com/lollipopkit/flutter_server_box/blob/860c11d4a8e9f86e7a6f1a109aa5dac6e5726c1d/linux/CMakeLists.txt#L44 instead

@iedame iedame mentioned this pull request Oct 12, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants