Skip to content

rocmPackages.mivisionx{-hip,-cpu}: remove libjpeg_turbo input#448970

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
LunNova:push-rtvmtwqxoomn
Oct 17, 2025
Merged

rocmPackages.mivisionx{-hip,-cpu}: remove libjpeg_turbo input#448970
JohnRTitor merged 1 commit intoNixOS:masterfrom
LunNova:push-rtvmtwqxoomn

Conversation

@LunNova
Copy link
Member

@LunNova LunNova commented Oct 5, 2025 •
edited
Loading

mivisionx no longer needs libjpeg_turbo so remove the input and get rid of the old overridden version.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. labels Oct 5, 2025
@LunNova LunNova added the 8.has: clean-up This PR removes packages or removes other cruft label Oct 5, 2025
@LunNova
rocmPackages.mivisionx{-hip,-cpu}: remove libjpeg_turbo input
e196425 
mivisionx no longer requires libjpeg_turbo
@LunNova LunNova marked this pull request as ready for review October 12, 2025 01:29
@LunNova
Copy link
Member Author

LunNova commented Oct 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448970
Commit: e196425fd8d3fc7fb39e2e39a710be87f68dfe11

x86_64-linux

✅ 2 packages built:
  • rocmPackages.mivisionx (rocmPackages.mivisionx-hip)
  • rocmPackages.mivisionx-cpu

@LunNova LunNova mentioned this pull request Oct 13, 2025
Merged
13 tasks
Flakebi
Flakebi approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks obviously fine, thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 13, 2025
@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 17, 2025
Merged via the queue into NixOS:master with commit ff2a647 Oct 17, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mschwaig mschwaig Awaiting requested review from mschwaig

@GZGavinZhao GZGavinZhao Awaiting requested review from GZGavinZhao

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

1 more reviewer

@Flakebi Flakebi Flakebi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LunNova @Flakebi @JohnRTitor