Skip to content

pocl: 7.0 -> 7.0-unstable-2025-09-30#448511

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
qbisi:pocl
Oct 5, 2025
Merged

pocl: 7.0 -> 7.0-unstable-2025-09-30#448511
JohnRTitor merged 1 commit intoNixOS:masterfrom
qbisi:pocl

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 4, 2025

Update to unstable branch to support compiling with llvm21 and gcc15.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qbisi qbisi changed the title pocl: build with llvmPackages20 pocl: build with llvm21 Oct 4, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 4, 2025
@qbisi qbisi changed the title pocl: build with llvm21 pocl: build with llvm20 Oct 4, 2025
Update to unstable branch to support compiling with llvm21 and gcc15.
@qbisi qbisi changed the title pocl: build with llvm20 pocl: 7.0 -> 7.0-unstable-2025-09-30 Oct 5, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 448511
Commit: 052c9b91b39f2ff76a3b3bfe57f3e5d1d422ee9f (subsequent changes)
Merge: a20b33c0e94e557cf66dc0fbd68f126c68e81e7e

Logs: https://github.com/qbisi/nixpkgs-review-gha/actions/runs/18256304587


x86_64-linux

✅ 9 packages built:
  • pocl
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python313Packages.pyopencl
  • python313Packages.pyopencl.dist
  • python313Packages.reikna
  • python313Packages.reikna.dist

aarch64-linux

✅ 9 packages built:
  • pocl
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python313Packages.pyopencl
  • python313Packages.pyopencl.dist
  • python313Packages.reikna
  • python313Packages.reikna.dist

x86_64-darwin (sandbox = true)

✅ 9 packages built:
  • pocl
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python313Packages.pyopencl
  • python313Packages.pyopencl.dist
  • python313Packages.reikna
  • python313Packages.reikna.dist

aarch64-darwin (sandbox = true)

✅ 9 packages built:
  • pocl
  • python312Packages.pyopencl
  • python312Packages.pyopencl.dist
  • python312Packages.reikna
  • python312Packages.reikna.dist
  • python313Packages.pyopencl
  • python313Packages.pyopencl.dist
  • python313Packages.reikna
  • python313Packages.reikna.dist

@qbisi qbisi marked this pull request as ready for review October 5, 2025 13:12
@nix-owners nix-owners bot requested review from JohnRTitor, jansol and xddxdd October 5, 2025 13:14
@jansol
Copy link
Contributor

jansol commented Oct 5, 2025

7.1 should be dropping shortly, is there a reason to rush the package update with an unstable bump?

@vcunat vcunat changed the base branch from staging-next to master October 5, 2025 13:35
@nixpkgs-ci nixpkgs-ci bot closed this Oct 5, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Oct 5, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 5, 2025

recent staging-next has upgrade llvm to 21. pocl is broken now.

Copy link
Contributor

@jansol jansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer switching the llvmPackages input to default to LLVM 20 until the relevant release, since nixpkgs carries versioned llvm packages anyway. But then again LLVM is "fun" and carries its own breakage risks when doing that.

Ideally we'd also have a LLVM version check in the derivation that fails it already at evaluation time when trying to build against an unsupported LLVM version. But that's more of a long term thing.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 5, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 5, 2025

I think I'd prefer switching the llvmPackages input to default to LLVM 20

My first attempt was trying to replace llvmPackages with llvmPackages_20, pocl build fine. However downsteam pyopencl segfault when doing check with pocl.

@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 5, 2025
Merged via the queue into NixOS:master with commit 73d0441 Oct 5, 2025
60 of 62 checks passed
@jansol
Copy link
Contributor

jansol commented Oct 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants