python: fix venv creation; resolve sys.prefix to realpath#448141
Draft
qbisi wants to merge 3 commits intoNixOS:masterfrom
Draft
python: fix venv creation; resolve sys.prefix to realpath#448141qbisi wants to merge 3 commits intoNixOS:masterfrom
qbisi wants to merge 3 commits intoNixOS:masterfrom
Conversation
Partially reverts NixOS#297628. The --resolve-argv0 option in makeWrapper does nothing, and no packages use it.
The --resolve-argv0 option was originally introduced in NixOS#297628 for wrapping Python executables. No other packages currently use it. This commit adjusts the behavior of --resolve-argv0: it now also resolves the dirname of argv0 to its realpath. This ensures that python venvs always resolve sys.base_prefix to the Nix store path (e.g., /nix/store/xxx-python3-env), regardless of how the Nix python environment's python is invoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt tring to fix python's sys.prefix not targetting the realpath in python-env or python-venv . See #442540
Before
After
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.