home-assistant-custom-components.pirate-weather: init at 1.8.3#447709
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Dec 26, 2025
Merged
home-assistant-custom-components.pirate-weather: init at 1.8.3#447709mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
ced57b7 to
3ba9465
Compare
Member
|
Please enable the tests. Per https://github.com/Pirate-Weather/pirate-weather-ha/blob/master/requirements_test.txt this requires
If you're not sure how to set up tests, check other components. |
f05104a to
cbe6b6b
Compare
Contributor
Author
|
That has tests enabled now, and I enabled the nix update script. |
Member
|
Ah sorry, the tests are only available in the next release. |
Contributor
Author
Was sure I checked if it had tests before creating the pr lol yeah they only just added, looks like the new release won't be far off if you want to wait and I'll make sure the tests run for that? |
Member
|
Either way is fine, but if you're not in a hurry we can wait for the next release. |
cbe6b6b to
488de4d
Compare
Contributor
Author
|
The new update is out, all tests passing |
488de4d to
31f3d40
Compare
31f3d40 to
3c98792
Compare
Contributor
Author
|
Is this good for merging? @mweinelt |
3c98792 to
8126f74
Compare
kfiz
pushed a commit
to kfiz/nixpkgs
that referenced
this pull request
Dec 26, 2025
kfiz
pushed a commit
to kfiz/nixpkgs
that referenced
this pull request
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the home assistant custom component pirate weather. https://github.com/Pirate-Weather/pirate-weather-ha
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.