Skip to content

home-assistant-custom-components.pirate-weather: init at 1.8.3#447709

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
CodedNil:pirateweather
Dec 26, 2025
Merged

home-assistant-custom-components.pirate-weather: init at 1.8.3#447709
mweinelt merged 1 commit intoNixOS:masterfrom
CodedNil:pirateweather

Conversation

@CodedNil
Copy link
Contributor

@CodedNil CodedNil commented Oct 1, 2025

Adds the home assistant custom component pirate weather. https://github.com/Pirate-Weather/pirate-weather-ha

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Oct 1, 2025
@nix-owners nix-owners bot requested a review from mweinelt October 1, 2025 13:17
@CodedNil CodedNil closed this Oct 2, 2025
@CodedNil CodedNil reopened this Oct 2, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Oct 2, 2025
@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2025

Please enable the tests.

Per https://github.com/Pirate-Weather/pirate-weather-ha/blob/master/requirements_test.txt this requires

  • pytestCheckHook
  • pytest-asyncio
  • pytest-homeassistant-custom-component.

If you're not sure how to set up tests, check other components.

@CodedNil
Copy link
Contributor Author

CodedNil commented Oct 4, 2025

That has tests enabled now, and I enabled the nix update script.

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2025

Ah sorry, the tests are only available in the next release.

@CodedNil
Copy link
Contributor Author

CodedNil commented Oct 4, 2025

Ah sorry, the tests are only available in the next release.

Was sure I checked if it had tests before creating the pr lol yeah they only just added, looks like the new release won't be far off if you want to wait and I'll make sure the tests run for that?

@mweinelt
Copy link
Member

mweinelt commented Oct 4, 2025

Either way is fine, but if you're not in a hurry we can wait for the next release.

@CodedNil CodedNil changed the title home-assistant-custom-components.pirate-weather: init at 1.7.7 home-assistant-custom-components.pirate-weather: init at 1.8b1 Nov 19, 2025
@CodedNil
Copy link
Contributor Author

The new update is out, all tests passing

@CodedNil CodedNil changed the title home-assistant-custom-components.pirate-weather: init at 1.8b1 home-assistant-custom-components.pirate-weather: init at 1.8 Nov 19, 2025
@CodedNil CodedNil changed the title home-assistant-custom-components.pirate-weather: init at 1.8 home-assistant-custom-components.pirate-weather: init at 1.8.2 Dec 6, 2025
@CodedNil
Copy link
Contributor Author

CodedNil commented Dec 6, 2025

Is this good for merging? @mweinelt

@CodedNil CodedNil changed the title home-assistant-custom-components.pirate-weather: init at 1.8.2 home-assistant-custom-components.pirate-weather: init at 1.8.3 Dec 25, 2025
@mweinelt mweinelt added this pull request to the merge queue Dec 26, 2025
Merged via the queue into NixOS:master with commit 2747a28 Dec 26, 2025
29 of 31 checks passed
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
kfiz pushed a commit to kfiz/nixpkgs that referenced this pull request Dec 26, 2025
@CodedNil CodedNil deleted the pirateweather branch January 23, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants