llvmPackages: clean up rebuild avoidance#447071
Merged
alyssais merged 8 commits intoNixOS:stagingfrom Sep 30, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
LunNova
force-pushed
the
push-lxxxmkoznort
branch
from
8934e21 to
f8160f7
Compare
LunNova
commented
Sep 29, 2025
Comment on lines
+105
to
+107
| ++ lib.optional (lib.versionAtLeast release_version "20") ( | ||
| lib.cmakeFeature "LLVM_DIR" "${libllvm.dev}/lib/cmake/llvm" | ||
| ) |
Member
Author
There was a problem hiding this comment.
I sorted LLVM_DIR up to here so that when llvm 19 is dropped it will already be in the right place instead of left in an unconditional ++ [ … ] at the bottom.
nix-owners
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
dtzWill,
emilazy,
lovek323,
rrbutani and
sternenseemann
LunNova
force-pushed
the
push-lxxxmkoznort
branch
from
f8160f7 to
957d7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild avoidance cleanup for
llvmPackagesTODOs from #440273 (@emilazy's big obsolete LLVM version drop PR) and #446207 (myenableClangToolsExtraPR)I hope #442017 lands so there's not a need to worry about rebuilds from
cmakeFlagsordering in the future.Things done
.#llvmPackages_{git,19}.lib{clang,llvm}{.tests.withoutOptionalFeatures,} .#llvmPackages_{git,19}.{lldb,lld,libunwind,openmp,libcxx,bolt,clangNoCompilerRtWithLibc}passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.