ocamlPackages.buildDunePackage: support fixed point args with lib.extendMkDerivation#446007
ocamlPackages.buildDunePackage: support fixed point args with lib.extendMkDerivation#446007vbgl merged 2 commits intoNixOS:masterfrom
lib.extendMkDerivation#446007Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
stepbrobd
force-pushed
the
ocaml
branch
2 times, most recently
from
9e0c95f to
65e1329
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
|
do i need to make the same change to |
| findlib | ||
| ] | ||
| ++ nativeBuildInputs; | ||
| checkPhase = |
There was a problem hiding this comment.
tried defaulting doCheck to true but some pkgs failed to build
might need to set it to false explicitly in those pkgs before defaulting this to true here
|
You can deal with topkg in a different PR. The oasis stuff, imho, should just be removed. |
| ... | ||
| }@args: | ||
| lib.extendMkDerivation { | ||
| constructDrv = stdenv.mkDerivation; |
There was a problem hiding this comment.
i haven't figure out with a way to replicate this behavior (stdenv' = args.stdenv or stdenv;) without adding another argument above lib.extendMkDerivation, but it seems that no in-tree code depends on this...
i personally think it'd be fine leaving this as is
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
| excludeDrvArgNames = [ | ||
| "minimalOCamlVersion" | ||
| "duneVersion" | ||
| ]; |
There was a problem hiding this comment.
Is there a reason why these have been excluded? it could be useful to know and access this information.
There was a problem hiding this comment.
Yes. This is meta-data that MUST NOT affect the hash.
There was a problem hiding this comment.
I see. What about inheriting them in passthru similar to what the python builder does?
3 participants
impl reference #382550 and #390220
btw i don't think there's the need to backport this to 2505 since 2511 will be released soon and i do think this will land before 2511 branch off ;)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.