Skip to content

[25.05] immich: 1.140.1 -> 1.142.0#445660

Merged
dotlambda merged 2 commits intoNixOS:release-25.05from
diogotcorreia:backport-441343-to-release-25.05
Sep 25, 2025
Merged

[25.05] immich: 1.140.1 -> 1.142.0#445660
dotlambda merged 2 commits intoNixOS:release-25.05from
diogotcorreia:backport-441343-to-release-25.05

Conversation

@diogotcorreia
Copy link
Member

Backport of:

Introduces a new vips_8_17 package due to the upgrade breaking haskellPackages.gi-vips. See #442486 for relevant discussion.

Closes #442486

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

See e424a29

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This report is automatically generated by the PR / Check / cherry-pick CI workflow.

Some of the commits in this PR require the author's and reviewer's attention.

Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.

If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.

Important

95f42bd is not a cherry-pick, because: upgrading vips causes a build failure in. Please review this commit manually.

Warning

Difference between de2c1da and original 5456b77 may warrant inspection.

Show diff
@@ Commit message
 
     Changelog: https://github.com/immich-app/immich/releases/tag/v1.141.1
                https://github.com/immich-app/immich/releases/tag/v1.142.0
+    (cherry picked from commit 5456b77d6c28c848d394b2a1c2164ce19de5ec95)
 
  ## pkgs/by-name/im/immich-cli/package.nix ##
 @@ pkgs/by-name/im/immich-cli/package.nix: let
@@ pkgs/by-name/im/immich-cli/package.nix: let
 
  ## pkgs/by-name/im/immich/package.nix ##
 @@
+   pango,
+   perl,
+   pixman,
+-  vips,
++  vips_8_17,
+   buildPackages,
  }:
  let
    pnpm = pnpm_10;
@@ pkgs/by-name/im/immich/package.nix: stdenv.mkDerivation {
      pixman
      # Required for sharp
 -    vips'
-+    vips
++    vips_8_17
    ];
  
    env.SHARP_FORCE_GLOBAL_LIBVIPS = 1;

Hint: The full diffs are also available in the runner logs with slightly better highlighting.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 4.workflow: backport This targets a stable branch labels Sep 23, 2025
@diogotcorreia diogotcorreia force-pushed the backport-441343-to-release-25.05 branch from 1328c5c to 3918878 Compare September 23, 2025 23:22
@dotlambda
Copy link
Member

The commit message should probably be vips_8_17: init at 8.17.1.

diogotcorreia and others added 2 commits September 24, 2025 11:22
Not-cherry-picked-because: upgrading vips causes a build failure in
haskellPackages.gi-vips, so a new package is added instead.
See NixOS@e424a29
@diogotcorreia diogotcorreia force-pushed the backport-441343-to-release-25.05 branch from 3918878 to de2c1da Compare September 24, 2025 10:23
@dotlambda
Copy link
Member

Any idea why the NixOS test fails?

@diogotcorreia
Copy link
Member Author

@dotlambda is it failing on the backup? That happened for me, but then I reran the test and it worked 🤔
I'll see if I can reproduce it again, might be a flaky test

@dotlambda
Copy link
Member

is it failing on the backup?

No, Postgres is failing to start. See https://logs.ofborg.org/?key=nixos/nixpkgs.445660&attempt_id=24e0bc4c-144b-4823-ad95-12eb8dedb95b.

@diogotcorreia
Copy link
Member Author

machine # [  343.950145] systemd[1]: postgresql.service: start-pre operation timed out. Terminating.
...
machine # [  369.675722] postgresql-pre-start[955]: Success. You can now start the database server using:

Seems like systemd times out waiting for postgres to start, but almost half a minute later postgres manages to start properly.
Could this be because ofborg is overwhelmed, or is this a regression?
I'm inclined to say it's the former because on my machine it takes only about 5 seconds for postgresql-pre-start to run (with and without vectorchord). But the log you sent is aarch64 and mine is x86_64, so there could be a difference there.

@dotlambda
Copy link
Member

If it runs fine on your machine, I guess we're good.

@dotlambda dotlambda dismissed github-actions[bot]’s stale review September 25, 2025 11:57

vips is outdated on 25.05

@dotlambda dotlambda added this pull request to the merge queue Sep 25, 2025
Merged via the queue into NixOS:release-25.05 with commit a55c480 Sep 25, 2025
28 of 31 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 25, 2025
@diogotcorreia diogotcorreia deleted the backport-441343-to-release-25.05 branch September 25, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants