[25.05] immich: 1.140.1 -> 1.142.0#445660
Conversation
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Sometimes it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts.
The range-diff will help to review the resolution of conflicts.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Important
95f42bd is not a cherry-pick, because: upgrading vips causes a build failure in. Please review this commit manually.
Warning
Difference between de2c1da and original 5456b77 may warrant inspection.
Show diff
@@ Commit message
Changelog: https://github.com/immich-app/immich/releases/tag/v1.141.1
https://github.com/immich-app/immich/releases/tag/v1.142.0
+ (cherry picked from commit 5456b77d6c28c848d394b2a1c2164ce19de5ec95)
## pkgs/by-name/im/immich-cli/package.nix ##
@@ pkgs/by-name/im/immich-cli/package.nix: let
@@ pkgs/by-name/im/immich-cli/package.nix: let
## pkgs/by-name/im/immich/package.nix ##
@@
+ pango,
+ perl,
+ pixman,
+- vips,
++ vips_8_17,
+ buildPackages,
}:
let
pnpm = pnpm_10;
@@ pkgs/by-name/im/immich/package.nix: stdenv.mkDerivation {
pixman
# Required for sharp
- vips'
-+ vips
++ vips_8_17
];
env.SHARP_FORCE_GLOBAL_LIBVIPS = 1;
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
1328c5c to
3918878
Compare
|
The commit message should probably be |
Not-cherry-picked-because: upgrading vips causes a build failure in haskellPackages.gi-vips, so a new package is added instead. See NixOS@e424a29
3918878 to
de2c1da
Compare
|
Any idea why the NixOS test fails? |
|
@dotlambda is it failing on the backup? That happened for me, but then I reran the test and it worked 🤔 |
No, Postgres is failing to start. See https://logs.ofborg.org/?key=nixos/nixpkgs.445660&attempt_id=24e0bc4c-144b-4823-ad95-12eb8dedb95b. |
Seems like systemd times out waiting for postgres to start, but almost half a minute later postgres manages to start properly. |
|
If it runs fine on your machine, I guess we're good. |
vips is outdated on 25.05
a55c480
Backport of:
Introduces a new
vips_8_17package due to the upgrade breakinghaskellPackages.gi-vips. See #442486 for relevant discussion.Closes #442486
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.
See e424a29