vscode/extensions/update_installed_exts.sh: log on download failure instead of early exit#445468
Open
schuelermine wants to merge 5 commits intoNixOS:masterfrom
Conversation
…nstead of early exit
…(shellcheck suggestion)
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
schuelermine
force-pushed
the
VSCode+extensions+update+script%3A+log+on+download+failure+instead+of+exit
branch
from
c0e8c00 to
03b52fe
Compare
Contributor
|
There are many problems with this script: #329271 |
…ncompatible with --fail
…ntirely superfluous, as far as I can tell
Contributor
Author
|
@qzylinra There may very well be other problems. This merge request fixes one specific problem that prevents the script from working for my use cases. I don’t think the possibility of fixing more things is an argument against this change. |
Contributor
Author
|
btw this is a cherry pick from my attempt to update the script more thoroughly #389795 |
nixpkgs-ci
bot
added
the
9.needs: reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the script not fail if you have local extensions that aren’t on the marketplace.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.