Skip to content

python3Packages.tkinter: fix python 3.11 compatibility#445166

Closed
sheepforce wants to merge 1 commit intoNixOS:stagingfrom
sheepforce:tkinter-fix
Closed

python3Packages.tkinter: fix python 3.11 compatibility#445166
sheepforce wants to merge 1 commit intoNixOS:stagingfrom
sheepforce:tkinter-fix

Conversation

@sheepforce
Copy link
Member

Fixes the python311 build of tkinter by adding missing dependencies and compiler flags.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 6.topic: python Python is a high-level, general-purpose programming language. labels Sep 22, 2025
@nix-owners nix-owners bot requested review from mweinelt and natsukium September 22, 2025 08:00
@sheepforce
Copy link
Member Author

Uh, this probably better targets staging, hu? 😅 Didn't expect that many packages depend on tkinter.

@sheepforce sheepforce changed the base branch from master to staging September 22, 2025 09:06
@nixpkgs-ci nixpkgs-ci bot closed this Sep 22, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Sep 22, 2025
github-actions[bot]

This comment was marked as resolved.

@github-actions github-actions bot dismissed their stale review September 22, 2025 09:09

All good now, thank you!

@mweinelt
Copy link
Member

There is also #442184. Have you tested any apps with this change?

@sheepforce
Copy link
Member Author

Ah actually no, I wasn't aware of the other one. That one does also work for our tkinter app, yes :)

@sheepforce
Copy link
Member Author

With #442184. being merged, this one can be closed, I think.

@sheepforce sheepforce closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants