rocmPackages: clean up, reduce closure sizes#444860
Merged
JohnRTitor merged 27 commits intoNixOS:masterfrom Oct 11, 2025
Merged
rocmPackages: clean up, reduce closure sizes#444860JohnRTitor merged 27 commits intoNixOS:masterfrom
JohnRTitor merged 27 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
This comment was marked as outdated.
This comment was marked as outdated.
LunNova
force-pushed
the
lunnova/rocm-dep-cleanup
branch
from
6346251 to
fa5c166
Compare
LunNova
force-pushed
the
lunnova/rocm-dep-cleanup
branch
2 times, most recently
from
afd11ac to
f8f86d4
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
LunNova
force-pushed
the
lunnova/rocm-dep-cleanup
branch
from
f8f86d4 to
40595af
Compare
nixpkgs-ci
bot
added
6.topic: llvm/clang
13 tasks
LunNova
added
the
8.has: clean-up
LunNova
changed the title
|
Down from over six gigs to one? You're a magician. |
LunNova
force-pushed
the
lunnova/rocm-dep-cleanup
branch
from
40595af to
2423ad8
Compare
… dev and then dealing with the consequences
rocm-path shouldn't have been added at top-level. We have a separate non-recursed section containing symlinkJoins for this, and best practice in nixpkgs is to avoid ROCM_PATH when possible and create a minimal one in each package that needs one.
LunNova
force-pushed
the
lunnova/rocm-dep-cleanup
branch
from
a0c114e to
c1cfcf3
Compare
nixpkgs-ci
bot
added
12.approvals: 1
qweered
approved these changes
Oct 8, 2025
nixpkgs-ci
bot
added
12.approvals: 2
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2581 |
categoricalcat
approved these changes
Oct 9, 2025
nixpkgs-ci
bot
added
12.approvals: 3+
Member
Author
|
@JohnRTitor you might also be interested in this PR that cuts down rocmPackages closure sizes |
JohnRTitor
approved these changes
Oct 11, 2025
Member
|
Member
|
Hi @LunNova! This PR unfortunately causes Davinci Resolve to hang loading projects when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure size before:
Closure size after:
Some ROCm packages had unnecessary git dependencies, mostly for CMakeLists that were doing find_package(Git REQUIRED) that have now been dropped upstream.
rocprofiler used to require libsystemd but no longer does
rocblas still insists on a git but swap it for gitMinimal.
various packages relied on the
rocm-merged-llvmsymlinkJoin in rocmPackages.llvm. This has been destroyed and direct deps plus occasional path patching have been applied instead.rocm's llvm toolchain that it needs at runtime no longer has refs to unneeded at runtime libllvm/libclang static libraries that took up well over a gigabyte.
rocm's llvm toolchain no longer includes
clang-tools-extra. no need forclang-tidyorclangdat runtime.Things done
nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.