Skip to content

Comments

rstudio: 2025.05.1+513 -> 2025.09.0+387#443875

Merged
jbedo merged 1 commit intoNixOS:masterfrom
TomaSajt:rstudio
Sep 19, 2025
Merged

rstudio: 2025.05.1+513 -> 2025.09.0+387#443875
jbedo merged 1 commit intoNixOS:masterfrom
TomaSajt:rstudio

Conversation

@TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Sep 17, 2025

https://github.com/rstudio/rstudio/blob/main/version/news/NEWS-2025.09.0-cucumberleaf-sunflower.md

The gwt helper files are no longer vendored, I had to fetch them.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Sep 17, 2025
@nix-owners nix-owners bot requested a review from ciil September 17, 2025 21:47
@b-rodrigues
Copy link
Contributor

b-rodrigues commented Sep 18, 2025

working on both x86_linux and aarch64-darwin

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 18, 2025
Kupac
Kupac approved these changes Sep 18, 2025
View reviewed changes
Copy link
Contributor

@Kupac Kupac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making quick work of this :) Both rstudioWrapper and rstudioServerWrapper are functional on x86_64-linux. The only issue remains the wrong working directory, but this can be addressed in a separate PR. Also, it only affects rstudio, and not rstudio-server (that one starts in the home dir of the user).

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 18, 2025
jbedo
jbedo approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@jbedo jbedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & fully functional

@jbedo jbedo added this pull request to the merge queue Sep 19, 2025
Merged via the queue into NixOS:master with commit 1b6d5e6 Sep 19, 2025
31 checks passed
@teutat3s teutat3s mentioned this pull request Nov 24, 2025
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbedo jbedo jbedo approved these changes

@ciil ciil Awaiting requested review from ciil

+2 more reviewers

@b-rodrigues b-rodrigues b-rodrigues approved these changes

@Kupac Kupac Kupac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomaSajt @b-rodrigues @jbedo @Kupac