Skip to content

wasmtime: fix pkgsStatic build#443365

Merged
sikmir merged 1 commit intoNixOS:masterfrom
nekowinston:wasmtime/fix-pkgsStatic-build
Oct 2, 2025
Merged

wasmtime: fix pkgsStatic build#443365
sikmir merged 1 commit intoNixOS:masterfrom
nekowinston:wasmtime/fix-pkgsStatic-build

Conversation

@nekowinston
Copy link
Member

@nekowinston nekowinston commented Sep 16, 2025

Fixes the postInstall as reported in #440501 (comment)
The rm currently fails in pkgsStatic.wasmtime because unlike pkgs.wasmtime.override { enableStatic = true; }, the .so can't be built in the first place.

Apologies to @jcaesar for overlooking this and breaking it.

I'm entirely confused why this PR seems to expect it to build *.so files for static targets anyway…

I copied the postInstall from tree-sitter assuming that someone had tested it via pkgsStatic, but it turns out the treesitter postInstall fails before it even reaches that line 🙃

Closes #444423

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 16, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 16, 2025
@ereslibre ereslibre added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 16, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 16, 2025
@jcaesar
Copy link
Contributor

jcaesar commented Sep 17, 2025

Apologies to @jcaesar for overlooking this and breaking it.

Don't worry and thank you for the PR.

I wonder, can I have a

@ofborg build pkgsStatic.wasmtime

@ereslibre
Copy link
Member

@jcaesar,

This is all I found relative to it: NixOS/ofborg#613, I don’t think it’s possible as of today.

@nekowinston
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 443365 -p wasmtime -p pkgsStatic.wasmtime
Commit: 08ff59ae8495c9b9a9fbd183ed47212db3d5a514 (subsequent changes)
Merge: 6d1556fbbc3f6b92de56484a0c3c020d74d424a3

Logs: https://github.com/nekowinston/nixpkgs-review-gha/actions/runs/17805358953

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-443365-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.winston.sh/public' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      public:gqpCDffg2eWolOCakuF0FhU0hmPHvOiBy2Z2rpyf8Mg=
      ' \
      /nix/store/pk1p5q6aaz8k4l638jnxmglvs5xsvldn-wasmtime-static-x86_64-unknown-linux-musl-36.0.2 \
      /nix/store/8laid0iahml5p7fj6fvh50p5rn5w5vga-wasmtime-static-x86_64-unknown-linux-musl-36.0.2-dev \
      /nix/store/1qzhz7v9hy1208yvcqnpf086hjp43040-wasmtime-36.0.2 \
      /nix/store/r3npx1zs18dl177nm1fkzazpbnnm5z74-wasmtime-36.0.2-dev
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-443365-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.winston.sh/public' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      public:gqpCDffg2eWolOCakuF0FhU0hmPHvOiBy2Z2rpyf8Mg=
      ' \
      /nix/store/7sbs62834sidqn4xda7x31ixgzngs2y9-wasmtime-static-aarch64-unknown-linux-musl-36.0.2 \
      /nix/store/rarsqa8agpyr8ih9rk0xw5a8hc0sh6mb-wasmtime-static-aarch64-unknown-linux-musl-36.0.2-dev \
      /nix/store/69m34ymbl1fc69n4pjr3j3xziq48w4j3-wasmtime-36.0.2 \
      /nix/store/mwc7k0hgzira9p8s9biaiw9x7wmlfc8b-wasmtime-36.0.2-dev
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-443365-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.winston.sh/public' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      public:gqpCDffg2eWolOCakuF0FhU0hmPHvOiBy2Z2rpyf8Mg=
      ' \
      /nix/store/1aar8dr2dspf4vwdkqnhnkkiii6llshf-wasmtime-static-x86_64-apple-darwin-36.0.2 \
      /nix/store/qmk3f0jk03b0nqa7n646l89dkfi3ly0n-wasmtime-static-x86_64-apple-darwin-36.0.2-dev \
      /nix/store/bwhwla5d6783ik7msmlfb1m8sdf2gxfj-wasmtime-36.0.2 \
      /nix/store/2hvkqn68y733byb5awa63zjc9wz76kdx-wasmtime-36.0.2-dev
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-443365-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.winston.sh/public' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      public:gqpCDffg2eWolOCakuF0FhU0hmPHvOiBy2Z2rpyf8Mg=
      ' \
      /nix/store/zk6vl5ib4r1wy7ps92xp3mb76ij1asim-wasmtime-static-arm64-apple-darwin-36.0.2 \
      /nix/store/syszjb9wnw9y59m6j4rx632jvsial11w-wasmtime-static-arm64-apple-darwin-36.0.2-dev \
      /nix/store/mndiw81jrf3ks07v34lask24y7zgnq72-wasmtime-36.0.2 \
      /nix/store/n1rrkd23s96l1w3h4xyfz3frpc0334kq-wasmtime-36.0.2-dev

x86_64-linux

✅ 4 packages built:
  • pkgsStatic.wasmtime
  • pkgsStatic.wasmtime.dev (pkgsStatic.wasmtime.dev.dev)
  • wasmtime
  • wasmtime.dev (wasmtime.dev.dev)

aarch64-linux

✅ 4 packages built:
  • pkgsStatic.wasmtime
  • pkgsStatic.wasmtime.dev (pkgsStatic.wasmtime.dev.dev)
  • wasmtime
  • wasmtime.dev (wasmtime.dev.dev)

x86_64-darwin (sandbox = true)

✅ 4 packages built:
  • pkgsStatic.wasmtime
  • pkgsStatic.wasmtime.dev (pkgsStatic.wasmtime.dev.dev)
  • wasmtime
  • wasmtime.dev (wasmtime.dev.dev)

aarch64-darwin (sandbox = true)

✅ 4 packages built:
  • pkgsStatic.wasmtime
  • pkgsStatic.wasmtime.dev (pkgsStatic.wasmtime.dev.dev)
  • wasmtime
  • wasmtime.dev (wasmtime.dev.dev)

@nekowinston nekowinston mentioned this pull request Sep 19, 2025
3 tasks
@nekowinston nekowinston added the 0.kind: build failure A package fails to build label Sep 19, 2025
@sikmir sikmir added this pull request to the merge queue Oct 2, 2025
Merged via the queue into NixOS:master with commit a0009c6 Oct 2, 2025
44 of 45 checks passed
@nekowinston nekowinston deleted the wasmtime/fix-pkgsStatic-build branch October 25, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: build failure A package fails to build 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: wasmtime

5 participants