Skip to content

[25.05] ci/eval/compare: add 10.rebuild-nixos-tests label#443191

Merged
wolfgangwalther merged 3 commits intoNixOS:release-25.05from
wolfgangwalther:backport-ci-nixos-rebuilds
Sep 15, 2025
Merged

[25.05] ci/eval/compare: add 10.rebuild-nixos-tests label#443191
wolfgangwalther merged 3 commits intoNixOS:release-25.05from
wolfgangwalther:backport-ci-nixos-rebuilds

Conversation

@wolfgangwalther
Copy link
Contributor

Manual backport of #439255

Conflict in the simple nixos test, because it was still using the old import ./make-test-python.nix etc. on stable.

We can't eval all nixos tests, this would be way too expensive. But we
can evaluate `nixosTests.simple` as an indication whether the nixos test
driver has changed. If that's the case, this means that *all* NixOS
tests need to be rebuilt.

(cherry picked from commit e3f583c)
This indicates that the NixOS test-driver changed and all NixOS tests
have to be rebuilt. It can be used to either re-target to staging or to
batch this with other similar changes, at least.

(cherry picked from commit 63e6fc4)
This should be a test that will change whenever most likely *all* NixOS
tests change. As such it should use the most "default" configuration
possible. This decreases chances of a change that will affect almost
other NixOS tests to go unnoticed by this test.

With the minimal profile used previously, there could be changes made to
the default behavior of NixOS modules which were explicitly disabled in
this profile. These would not change the simple test, but would change
all other tests.

Removing as many moving parts as possible from this test should make it
the most default it can be. It now contains only pieces that every other
NixOS test has, too: A name, a machine and a testScript. But nothing
fancy.

(cherry picked from commit 6d90bae)
github-actions[bot]

This comment was marked as resolved.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 4.workflow: backport This targets a stable branch labels Sep 15, 2025
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

@wolfgangwalther wolfgangwalther merged commit 04389cd into NixOS:release-25.05 Sep 15, 2025
33 of 37 checks passed
@wolfgangwalther wolfgangwalther deleted the backport-ci-nixos-rebuilds branch September 15, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants