Skip to content

openssl: Enable tests, add missing patch comments #443190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
infinisil wants to merge 2 commits into from
Closed

openssl: Enable tests, add missing patch comments #443190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2838ffb
openssl: Enable tests
infinisil Sep 15, 2025
a31a53e
openssl: Add missing comments for patches
infinisil Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkgs/development/libraries/openssl/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,11 @@ let

enableParallelBuilding = true;

doCheck = true;
preCheck = ''
patchShebangs util
'';

postInstall =
(
if static then
Expand Down Expand Up @@ -367,12 +372,15 @@ in
hash = "sha256-39135OobV/86bb3msL3D8x21rJnn/dTq+eH7tuwtuM4=";

patches = [
# Support for NIX_SSL_CERT_FILE, motivation unclear:
Copy link
Contributor

@thillux thillux Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Motivation for this patch is given here: 942dbf8

# https://github.com/NixOS/nixpkgs/issues/385955
./3.0/nix-ssl-cert-file.patch

# openssl will only compile in KTLS if the current kernel supports it.
# This patch disables build-time detection.
./3.0/openssl-disable-kernel-detection.patch

# Look up SSL certificates in /etc rather than the immutable installation directory
(
if stdenv.hostPlatform.isDarwin then ./use-etc-ssl-certs-darwin.patch else ./use-etc-ssl-certs.patch
)
Expand All @@ -390,12 +398,15 @@ in
hash = "sha256-UpBDsVz/pfNgd6TQr4Pz3jmYBxgdYHRB1zQZbYibZB8=";

patches = [
# Support for NIX_SSL_CERT_FILE, motivation unclear:
# https://github.com/NixOS/nixpkgs/issues/385955
Comment on lines 401 to 402
Copy link
Contributor

@fzakaria fzakaria Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

./3.0/nix-ssl-cert-file.patch

# openssl will only compile in KTLS if the current kernel supports it.
# This patch disables build-time detection.
./3.0/openssl-disable-kernel-detection.patch

# Look up SSL certificates in /etc rather than the immutable installation directory
(
if stdenv.hostPlatform.isDarwin then
./3.5/use-etc-ssl-certs-darwin.patch
Expand Down
Loading