Skip to content

aliases: correct extra "throw", add missing dates#442683

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
mdaniels5757:fix-aliases
Sep 14, 2025
Merged

aliases: correct extra "throw", add missing dates#442683
wolfgangwalther merged 1 commit intoNixOS:masterfrom
mdaniels5757:fix-aliases

Conversation

@mdaniels5757
Copy link
Member

Should help with automated efforts to reduce the size of aliases.nix, either through #427017, #442066, or some other solution.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 13, 2025
@wolfgangwalther
Copy link
Contributor

Seems like I have some more in c2d9a1c from a quick glance. Maybe you want to incorporate some of these here as well?

@wolfgangwalther
Copy link
Contributor

Also, I'm not sure whether that is in the linked commit, please apply this:

-  vtk_9_withQt5 = throw "'vtk_9_withQt5' has been removed, Consider using 'vtkWithQt5' instead." vtkWithQt5; # Added 2025-07-18
+  vtk_9_withQt5 = throw "'vtk_9_withQt5' has been removed, Consider using 'vtkWithQt5' instead."; # Added 2025-07-18

@mdaniels5757 mdaniels5757 force-pushed the fix-aliases branch 2 times, most recently from 67e88e8 to 1737cb7 Compare September 13, 2025 19:39
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really looks like it shouldn't be an alias, but out of scope for here.

correct extra "throw", punctuation, and vtk_9_withQt5, also add missing dates

Co-authored-by: Wolfgang Walther <walther@technowledgy.de>
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Sep 14, 2025
Merged via the queue into NixOS:master with commit a58135c Sep 14, 2025
27 of 31 checks passed
@mdaniels5757 mdaniels5757 deleted the fix-aliases branch September 14, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants