Skip to content

nixos/gpu-screen-recorder: remove cap_sys_nice, again#442391

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
js6pak:gpu-screen-recorder/remove-nicecap
Oct 5, 2025
Merged

nixos/gpu-screen-recorder: remove cap_sys_nice, again#442391
jopejoe1 merged 1 commit intoNixOS:masterfrom
js6pak:gpu-screen-recorder/remove-nicecap

Conversation

@js6pak
Copy link
Member

@js6pak js6pak commented Sep 12, 2025

It now breaks portal capture again, and should have been removed when updating to 5.5.6.

#369574 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@js6pak
nixos/gpu-screen-recorder: remove cap_sys_nice, again
b53dab9 
It now breaks portal capture again, and should have been removed when updating to 5.5.6.
@js6pak js6pak mentioned this pull request Sep 12, 2025
Open
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Sep 12, 2025
timschumi
timschumi approved these changes Oct 4, 2025
View reviewed changes
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches current upstream scripts, approved.

Not sure why I didn't get notified for this.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 4, 2025
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 5, 2025
Merged via the queue into NixOS:master with commit 5ad1786 Oct 5, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@timschumi timschumi timschumi approved these changes

@keenanweaver keenanweaver keenanweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@js6pak @timschumi @keenanweaver @jopejoe1