tcpreplay: Fix build after splitting libpcap to multiple outputs#442048
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Sep 11, 2025
Merged
tcpreplay: Fix build after splitting libpcap to multiple outputs#442048philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
pbsds
reviewed
Sep 11, 2025
Configure file of tcpreplay expects that libpcap header files and libraries share the same prefix. Since [1] this is no longer true so we have to patch the configure script. [1]: NixOS@da89a2d
wentasah
force-pushed
the
fix-tcpreplay
branch
from
0d5ba0d to
d0a565c
Compare
Contributor
|
philiptaron
approved these changes
Sep 11, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
philiptaron
reviewed
Sep 11, 2025
Comment on lines
+20
to
+25
| # Allow having different prefix for header files (default output | ||
| # "out") and libraries ("lib" output) | ||
| postPatch = '' | ||
| substituteInPlace configure \ | ||
| --replace-fail 'ls ''${testdir}/$dir/libpcap' 'ls ${lib.getLib libpcap}/$dir/libpcap' | ||
| ''; |
Contributor
There was a problem hiding this comment.
While this works, my preferred fix would be to patch out this monstrosity with something correct for building with Nix, where we understand exaction where libpcap is and where its headers are.
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes recent build failure.
Configure file of tcpreplay expects that libpcap header files and libraries share the same prefix. Since commit 1 (#429972) this is no longer true so we have to patch the configure script.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.