Skip to content

Comments

libiconv: update to 1.14#4419

Closed
vbgl wants to merge 2 commits intoNixOS:masterfrom
vbgl:libiconv
Closed

libiconv: update to 1.14#4419
vbgl wants to merge 2 commits intoNixOS:masterfrom
vbgl:libiconv

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Oct 8, 2014

No description provided.

@vcunat
Copy link
Member

vcunat commented Oct 18, 2014

Some of you did test this, right?

@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label Oct 18, 2014
@vcunat
Copy link
Member

vcunat commented Oct 25, 2014

This fails building on Linux. I thought it was no problem, but some packages we have explicitly link against this libintl even on Linux. I don't really know why. Any ideas?

Example: aegisub; others seen in http://hydra.nixos.org/eval/1156552?compare=1156478&full=1#tabs-now-fail.

@vcunat vcunat mentioned this pull request Oct 25, 2014
Closed
@vbgl
Copy link
Contributor Author

vbgl commented Oct 29, 2014

Indeed, libiconv 1.14 does not build on Linux. This is an issue. I don’t think I can (look at how to) fix it now. So I won’t mind if this PR is closed without merging.

On the other hand, thanks a lot for your testing vcunat. I’ve just pushed an other commit that should fix the failures you’ve observed and that are due to libiconv. I think that the second commit is independent from the first one and is useful on its own.

There is still one derivation that explicitly requires libiconv: vagrant. I don’t know how to fix it.

@vcunat
Copy link
Member

vcunat commented Oct 30, 2014

CC vagrant maint. @lovek323: any idea whether external libiconv is really needed for vagrant on linux (instead of the glibc builtin)?

@lovek323
Copy link
Member

lovek323 commented Oct 31, 2014

@vcunat: Nope. Haven't tested it either way.

vcunat added a commit that referenced this pull request Nov 3, 2014
@vcunat
aegisub: do not force libiconv, use auto link flags
0ff8281 
This fixes build after #4419.
It seems to start fine without the flags, CC maint. @AndersonTorres.
vcunat added a commit that referenced this pull request Nov 3, 2014
@vcunat
vagrant: use bin/iconv from glibc on Linux
5b00625 
This fixes build after #4419.
vcunat added a commit that referenced this pull request Nov 3, 2014
@vcunat
iconv: remove usage on Linux in several packages
ed867a5 
This fixes builds after #4419. Thanks to @vbgl for the original commit;
I changed that as I'm not sure whether passing null values to buildInputs is clean.

CC maintainers: @coroa, @peti, @Phreedom, @robberer, @jcumming.
@vcunat
Copy link
Member

vcunat commented Nov 3, 2014

OK, I think I've fixed almost all now.

@vbgl vbgl closed this in a9f37a8 Nov 14, 2014
@vbgl vbgl deleted the libiconv branch November 14, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vbgl @vcunat @lovek323 @wmertens @pSub